bpf: rename BTF_KIND_TAG to BTF_KIND_DECL_TAG #1912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: 5319255 |
|
Master branch: 431bfb9 |
kernel-patches-bot
force-pushed
the
series/560809=>bpf-next
branch
from
fba91f7
to
3b7c40e
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=560809 expired. Closing PR. |
|
Master branch: 431bfb9 |
kernel-patches-bot
force-pushed
the
series/560809=>bpf-next
branch
from
3b7c40e
to
ce15fd4
Compare
Patch set [1] introduced BTF_KIND_TAG to allow tagging declarations for struct/union, struct/union field, var, func and func arguments and these tags will be encoded into dwarf. They are also encoded to btf by llvm for the bpf target. After BTF_KIND_TAG is introduced, we intended to use it for kernel __user attributes. But kernel __user is actually a type attribute. Upstream and internal discussion showed it is not a good idea to mix declaration attribute and type attribute. So we proposed to introduce btf_type_tag as a type attribute and existing btf_tag renamed to btf_decl_tag ([2]). This patch renamed BTF_KIND_TAG to BTF_KIND_DECL_TAG and some other declarations with *_tag to *_decl_tag to make it clear the tag is for declaration. In the future, BTF_KIND_TYPE_TAG might be introduced per [3]. [1] https://lore.kernel.org/bpf/20210914223004.244411-1-yhs@fb.com/ [2] https://reviews.llvm.org/D111588 [3] https://reviews.llvm.org/D111199 Fixes: b5ea834 ("bpf: Support for new btf kind BTF_KIND_TAG") Fixes: 5b84bd1 ("libbpf: Add support for BTF_KIND_TAG") Fixes: 5c07f2f ("bpftool: Add support for BTF_KIND_TAG") Signed-off-by: Yonghong Song <yhs@fb.com>
|
Master branch: 431bfb9 |
kernel-patches-bot
force-pushed
the
series/560809=>bpf-next
branch
from
ce15fd4
to
9526f85
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=561987 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: rename BTF_KIND_TAG to BTF_KIND_DECL_TAG
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=560809