Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME #1915

Closed
wants to merge 4 commits into from
Closed

libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME #1915

wants to merge 4 commits into from

Conversation

kernel-patches-bot
Copy link

Pull request for series with
subject: libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=561249

@kernel-patches-bot
Copy link
Author

Master branch: 431bfb9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561249
version: 1

@kernel-patches-bot
Copy link
Author

Master branch: 431bfb9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot kernel-patches-bot added V2 and removed V1 labels Oct 12, 2021
@kernel-patches-bot
Copy link
Author

Master branch: 223f903
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 32fa0ef
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 588cd7e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 588cd7e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: ebc7b50
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: b599015
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=561959
version: 2

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=561959 expired. Closing PR.

@kernel-patches-bot
Copy link
Author

Master branch: 99aaebf
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=567379
version: 3

@kernel-patches-bot
Copy link
Author

Master branch: db5b6a4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot kernel-patches-bot added V5 and removed V4 labels Oct 21, 2021
@kernel-patches-bot
Copy link
Author

Master branch: 44ce0ac
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

Master branch: 549beec
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

Master branch: b0c7663
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

Master branch: 29da17c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

Master branch: 57385ae
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

Master branch: 1000298
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

Master branch: 59f2a29
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

Nobody and others added 4 commits October 22, 2021 16:53
adding ci files
e972d5a
@fomichev
libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME
ad3cf9b 
We can't use section name anymore because they are not unique
and pinning objects with multiple programs with the same
progtype/secname will fail.

Closes: libbpf/libbpf#273
Fixes: 33a2c75 ("libbpf: add internal pin_name")
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Stanislav Fomichev <sdf@google.com>
@fomichev
bpftool: conditionally append / to the progtype
23efdc0 
Otherwise, attaching with bpftool doesn't work with strict section names.

Also, switch to libbpf strict mode to use the latest conventions
(note, I don't think we have any cli api guarantees?).

Cc: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
@fomichev
selftests/bpf: fix flow dissector tests
57d243b 
- update custom loader to search by name, not section name
- update bpftool commands to use proper pin path

Signed-off-by: Stanislav Fomichev <sdf@google.com>
@kernel-patches-bot
Copy link
Author

Master branch: e89ef63
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=568209
version: 5

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=568209 irrelevant now. Closing PR.

@kernel-patches-bot kernel-patches-bot deleted the series/561249=>bpf-next branch October 23, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accepted bpf-next changes-requested V5
Projects
None yet
Milestone
No milestone
2 participants
@kernel-patches-bot @fomichev