bpf: Minor fixes #3236
Closed
bpf: Minor fixes #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: c5c7358 |
|
Master branch: d17b557 |
kernel-patches-bot
force-pushed
the
series/655094=>bpf-next
branch
from
7eb0af4
to
b42b655
Compare
|
Master branch: f0cf642 |
kernel-patches-bot
force-pushed
the
series/655094=>bpf-next
branch
from
b42b655
to
c18d06e
Compare
|
Master branch: b0cbd61 |
kernel-patches-bot
force-pushed
the
series/655094=>bpf-next
branch
from
c18d06e
to
f61300c
Compare
|
Master branch: 6d30487 |
kernel-patches-bot
force-pushed
the
series/655094=>bpf-next
branch
from
f61300c
to
616b7e7
Compare
GFP_ATOMIC doesn't cooperate well with memcg pressure so far, especially if we allocate too much GFP_ATOMIC memory. For example, when we set the memcg limit to limit a non-preallocated bpf memory, the GFP_ATOMIC can easily break the memcg limit by force charge. So it is very dangerous to use GFP_ATOMIC in non-preallocated case. One way to make it safe is to remove __GFP_HIGH from GFP_ATOMIC, IOW, use (__GFP_ATOMIC | __GFP_KSWAPD_RECLAIM) instead, then it will be limited if we allocate too much memory. We introduced BPF_F_NO_PREALLOC is because full map pre-allocation is too memory expensive for some cases. That means removing __GFP_HIGH doesn't break the rule of BPF_F_NO_PREALLOC, but has the same goal with it-avoiding issues caused by too much memory. So let's remove it. __GFP_KSWAPD_RECLAIM doesn't cooperate well with memcg pressure neither currently. But the memcg code can be improved to make __GFP_KSWAPD_RECLAIM work well under memcg pressure. It also fixes a typo in the comment. Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Cc: Roman Gushchin <roman.gushchin@linux.dev>
BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are trace type as well, which may also cause unexpected memory allocation if we set BPF_F_NO_PREALLOC. Let's also warn on both of them. Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
|
Master branch: 39e940d |
It doesn't need to do the preempt check when migrate is disabled after commit 74d862b ("sched: Make migrate_disable/enable() independent of RT"). Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
For example, /sys/fs/bpf/maps.debug is a bpf link, when you run `bpftool map show` to show it, - before $ bpftool map show pinned /sys/fs/bpf/maps.debug Error: incorrect object type: unknown - after $ bpftool map show pinned /sys/fs/bpf/maps.debug Error: incorrect object type: link Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
kernel-patches-bot
force-pushed
the
series/655094=>bpf-next
branch
from
616b7e7
to
ba42576
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=655094 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Minor fixes
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=655094