Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selftests/bpf: Add benchmark for local_storage RCU Tasks Trace usage #3255

Closed
wants to merge 2 commits into from

Conversation

kernel-patches-bot
Copy link

Pull request for series with
subject: selftests/bpf: Add benchmark for local_storage RCU Tasks Trace usage
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=656505

@kernel-patches-bot
Copy link
Author

Master branch: b0d93b4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656505
version: 3

@kernel-patches-bot
Copy link
Author

Master branch: 990a619
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656505
version: 3

@kernel-patches-bot
Copy link
Author

Master branch: cfb5a2d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656505
version: 3

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=656505 expired. Closing PR.

@kernel-patches-bot
Copy link
Author

Master branch: cfb5a2d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: f6b9f6d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: e4adcee
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: 450a8dc
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: 7c8121a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: f44294e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: 7c8121a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

@kernel-patches-bot
Copy link
Author

Master branch: 935dc35
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=656771
version: 4

Kernel Patches Daemon and others added 2 commits July 7, 2022 07:35
This benchmark measures grace period latency and kthread cpu usage of
RCU Tasks Trace when many processes are creating/deleting BPF
local_storage. Intent here is to quantify improvement on these metrics
after Paul's recent RCU Tasks patches [0].

Specifically, fork 15k tasks which call a bpf prog that creates/destroys
task local_storage and sleep in a loop, resulting in many
call_rcu_tasks_trace calls.

To determine grace period latency, trace time elapsed between
rcu_tasks_trace_pregp_step and rcu_tasks_trace_postgp; for cpu usage
look at rcu_task_trace_kthread's stime in /proc/PID/stat.

On my virtualized test environment (Skylake, 8 cpus) benchmark results
demonstrate significant improvement:

BEFORE Paul's patches:

  SUMMARY tasks_trace grace period latency        avg 22298.551 us stddev 1302.165 us
  SUMMARY ticks per tasks_trace grace period      avg 2.291 stddev 0.324

AFTER Paul's patches:

  SUMMARY tasks_trace grace period latency        avg 16969.197 us  stddev 2525.053 us
  SUMMARY ticks per tasks_trace grace period      avg 1.146 stddev 0.178

Note that since these patches are not in bpf-next benchmarking was done
by cherry-picking this patch onto rcu tree.

  [0]: https://lore.kernel.org/rcu/20220620225402.GA3842369@paulmck-ThinkPad-P17-Gen-1/

Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=656771 irrelevant now. Closing PR.

@kernel-patches-bot kernel-patches-bot deleted the series/653373=>bpf-next branch July 7, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants