clean-up bpftool from legacy support #4012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: b548b17 |
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
374ee0d
to
acf8d80
Compare
|
Upstream branch: f12ed9c |
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
e121dfc
to
b825875
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
acf8d80
to
23d1c50
Compare
|
Upstream branch: dfd0afb |
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
b825875
to
02b310a
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
23d1c50
to
2d4b4cb
Compare
|
Upstream branch: e662c77 |
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
02b310a
to
db2a71f
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
2d4b4cb
to
b8b18fc
Compare
|
Upstream branch: bd56f86 |
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
db2a71f
to
eff18c0
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
b8b18fc
to
63a05f7
Compare
|
Upstream branch: 6728aea |
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
eff18c0
to
b594c90
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
63a05f7
to
d518379
Compare
|
Upstream branch: 26a9b43 |
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
b594c90
to
fa5805e
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
d518379
to
28b3d16
Compare
Following: commit bd05410 ("libbpf: enforce strict libbpf 1.0 behaviors") commit 93b8952 ("libbpf: deprecate legacy BPF map definitions") The --legacy option is no longer relevant as libbpf no longer supports it. libbpf_set_strict_mode() is a no-op operation. Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com> Acked-by: Yonghong Song <yhs@fb.com> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
There is no reasons to keep PTR_ERR() when kern_btf=NULL, let's just return 0. This also cleans this part of code from using libbpf_get_error(). Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com> Acked-by: Yonghong Song <yhs@fb.com>
It is expected that errno be passed to strerror(). This also cleans this part of code from using libbpf_get_error(). Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com> Acked-by: Yonghong Song <yhs@fb.com> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
bpftool is now totally compliant with libbpf 1.0 mode and is not expected to be compiled with pre-1.0, let's clean-up the usage of libbpf_get_error(). The changes stay aligned with returned errors always negative. - In tools/bpf/bpftool/btf.c This fixes an unintialized local variable `err` in function do_dump() because it may now be returned without having been set. - This also removes the checks on NULL pointers before calling btf__free() because that function already does the check. Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com>
|
Upstream branch: 32637e3 |
The function contains a single btf__free() call which can be inlined. Credits to Yonghong Song. Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com> Acked-by: Yonghong Song <yhs@fb.com> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
kernel-patches-bot
force-pushed
the
series/693282=>bpf-next
branch
from
fa5805e
to
5c7340f
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
28b3d16
to
ccb2000
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=694820 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: clean-up bpftool from legacy support
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=694820