selftests/xsk: three small fixes #4027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 5fd2a60 |
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
5e4048b
to
03aa0c5
Compare
Print the correct payload when the packet dump option is selected. The network to host conversion was forgotten and the payload was erronously declared to be an int instead of an unsigned int. Changed the loop index i too, as it does not need to be an int and was declared on the same row. The printout looks something like this after the fix: DEBUG>> L2: dst mac: 000A569EEE62 DEBUG>> L2: src mac: 000A569EEE61 DEBUG>> L3: ip_hdr->ihl: 05 DEBUG>> L3: ip_hdr->saddr: 192.168.100.161 DEBUG>> L3: ip_hdr->daddr: 192.168.100.162 DEBUG>> L4: udp_hdr->src: 2121 DEBUG>> L4: udp_hdr->dst: 2020 DEBUG>> L5: payload: 4 --------------------------------------- Fixes: facb7cb ("selftests/bpf: Xsk selftests - SKB POLL, NOPOLL") Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Do not close descriptors that have never been used. File descriptor fields that are not in use are erroneously marked with the number 0, which is a valid fd. Mark unused fds with -1 instead and do not close these when deleting the socket. Fixes: f366006 ("libbpf: move xsk.{c,h} into selftests/bpf") Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Print the correct error codes when exiting the test suite due to some terminal error. Some of these had a switched sign and some of them printed zero instead of errno. Fixes: facb7cb ("selftests/bpf: Xsk selftests - SKB POLL, NOPOLL") Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
|
Upstream branch: 47df8a2 |
kernel-patches-bot
force-pushed
the
series/695399=>bpf
branch
from
49a6fc7
to
a6d0e58
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=695399 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/xsk: three small fixes
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=695399