bpftool: Check argc first before "file" in do_batch() #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 6728aea |
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
63a05f7
to
d518379
Compare
|
Upstream branch: 26a9b43 |
kernel-patches-bot
force-pushed
the
series/695535=>bpf-next
branch
from
4af9ec4
to
21e0873
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
d518379
to
28b3d16
Compare
|
Upstream branch: 32637e3 |
kernel-patches-bot
force-pushed
the
series/695535=>bpf-next
branch
from
21e0873
to
1859e63
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
28b3d16
to
ccb2000
Compare
|
Upstream branch: 6373ef1 |
kernel-patches-bot
force-pushed
the
series/695535=>bpf-next
branch
from
1859e63
to
206d230
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
ccb2000
to
294adfe
Compare
|
Upstream branch: e0eb608 |
If the parameters for batch are more than 2, check argc first can return immediately, no need to use is_prefix() to check "file" with a little overhead and then check argc, it is better to check "file" only when the parameters for batch are 2. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Acked-by: Stanislav Fomichev <sdf@google.com> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
kernel-patches-bot
force-pushed
the
series/695535=>bpf-next
branch
from
206d230
to
bceb713
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
294adfe
to
d238c4e
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=695535 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpftool: Check argc first before "file" in do_batch()
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=695535