Split page pools from struct page #4126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: f8186bf |
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
c658e2c
to
96164dd
Compare
|
Upstream branch: 59b8436 |
kernel-patches-bot
force-pushed
the
series/700610=>bpf-next
branch
from
53758de
to
8e3edb3
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
96164dd
to
8eb0bd8
Compare
|
Upstream branch: 996c060 |
kernel-patches-bot
force-pushed
the
series/700610=>bpf-next
branch
from
8e3edb3
to
0330c69
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
8eb0bd8
to
45e5b41
Compare
|
Upstream branch: c67cae5 |
kernel-patches-bot
force-pushed
the
series/700610=>bpf-next
branch
from
0330c69
to
84f8394
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
45e5b41
to
9860b49
Compare
|
Upstream branch: 89903dc |
kernel-patches-bot
force-pushed
the
series/700610=>bpf-next
branch
from
84f8394
to
53574b3
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
9860b49
to
85c0283
Compare
added 12 commits
November 30, 2022 17:33
As part of simplifying struct page, create a new netmem type which mirrors the page_pool members in struct page. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
netmem_page() is defined this way to preserve constness. page_netmem() doesn't call compound_head() because netmem users always use the head page; it does include a debugging assert to check that it's true. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Turn page_pool_set_dma_addr() and page_pool_get_dma_addr() into wrappers. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
…em() Also convert page_pool_clear_pp_info() and trace_page_pool_state_release() to take a netmem. Include a wrapper for page_pool_release_page() to avoid converting all callers. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Convert __page_pool_alloc_page_order() and __page_pool_alloc_pages_slow() to use netmem internally. This removes a couple of calls to compound_head() that are hidden inside put_page(). Convert trace_page_pool_state_hold(), page_pool_dma_map() and page_pool_set_pp_info() to take a netmem argument. Saves 83 bytes of text in __page_pool_alloc_page_order() and 98 in __page_pool_alloc_pages_slow() for a total of 181 bytes. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Removes a call to compound_head(), saving 464 bytes of kernel text as page_pool_return_page() is inlined seven times. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Removes the call to compound_head() hidden in put_page() which saves 169 bytes of kernel text as __page_pool_put_page() is inlined twice. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Change the type here from page to netmem. It works out well to convert page_pool_refill_alloc_cache() to return a netmem instead of a page as part of this commit. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Add a page_pool_defrag_page() wrapper. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Also convert page_pool_is_last_frag(), page_pool_put_page(), page_pool_recycle_in_ring() and use netmem in page_pool_put_page_bulk(). Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Retrieve a netmem from the ptr_ring instead of a page. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Add a page_pool_alloc_pages() compatibility wrapper. Also convert __page_pool_alloc_pages_slow() to __page_pool_alloc_netmem_slow() and __page_pool_alloc_page_order() to __page_pool_alloc_netmem(). __page_pool_get_cached() is converted to return a netmem. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
added 11 commits
November 30, 2022 17:33
Change all callers. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Removes a few casts. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
This wrapper is no longer used. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
We're not quite ready to change the API of page_pool_drain_frag(), but we can remove the use of several wrappers by using the netmem throughout. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
This function accesses the pagepool members of struct page directly, so it needs to become netmem. Add page_pool_put_full_netmem(). Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Remove page_pool_defrag_page() and page_pool_return_page() as they have no more callers. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
We dereference the 'pp' member of struct page, so we must use a netmem here. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
These are now split out into their own netmem struct. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Convert the only user of init_callback. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Allow drivers to add netmem to skbs & retrieve them again. If the VM_BUG_ON triggers, we can add a call to compound_head() either in this function or in page_netmem(). Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
|
Upstream branch: 3144bfa |
Use the netmem APIs instead of the page APIs. Improves type-safety. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
kernel-patches-bot
force-pushed
the
series/700610=>bpf-next
branch
from
53574b3
to
ebc6a26
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
85c0283
to
ab07846
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=700610 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Split page pools from struct page
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=700610