riscv, bpf: Emit fixed-length instructions for BPF_PSEUDO_FUNC #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 01f856a |
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
c0864d5
to
ffd4ac7
Compare
|
Upstream branch: 01f856a |
kernel-patches-bot
force-pushed
the
series/701179=>bpf
branch
from
7f0840e
to
cdff1a2
Compare
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
ffd4ac7
to
78db815
Compare
|
Upstream branch: e931a17 |
kernel-patches-bot
force-pushed
the
series/701179=>bpf
branch
from
cdff1a2
to
a20a310
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=701179 expired. Closing PR. |
For BPF_PSEUDO_FUNC instruction, verifier will refill imm with correct addresses of bpf_calls and then run last pass of JIT. Since the emit_imm of RV64 is variable-length, which will emit appropriate length instructions accorroding to the imm, it may broke ctx->offset, and lead to unpredictable problem, such as inaccurate jump. So let's fix it with fixed-length instructions. Fixes: 69c087b ("bpf: Add bpf_for_each_map_elem() helper") Signed-off-by: Pu Lehui <pulehui@huawei.com> Suggested-by: Björn Töpel <bjorn@rivosinc.com>
|
Upstream branch: e931a17 |
kernel-patches-bot
force-pushed
the
series/701179=>bpf
branch
from
a20a310
to
31e8e51
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=702120 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: riscv, bpf: Emit fixed-length instructions for BPF_PSEUDO_FUNC
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=701179