bpf: Resolve fext program type when checking map compatibility #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 01de112 |
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
1f465df
to
aaa7f18
Compare
|
Upstream branch: 01de112 |
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
5a615a9
to
a1e2855
Compare
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
aaa7f18
to
2214092
Compare
|
Upstream branch: 01de112 |
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
a1e2855
to
65c74cf
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=704318 expired. Closing PR. |
|
Upstream branch: 01de112 |
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
65c74cf
to
d95b49e
Compare
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
2214092
to
f66d205
Compare
|
Upstream branch: 7ae9888 |
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
d95b49e
to
1577ca3
Compare
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
f66d205
to
b747b99
Compare
|
Upstream branch: e89f3ed |
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
1577ca3
to
143b971
Compare
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
b747b99
to
6e3baff
Compare
|
Upstream branch: 4121d44 |
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
143b971
to
b58f8e0
Compare
The bpf_prog_map_compatible() check makes sure that BPF program types are not mixed inside BPF map types that can contain programs (tail call maps, cpumaps and devmaps). It does this by setting the fields of the map->owner struct to the values of the first program being checked against, and rejecting any subsequent programs if the values don't match. One of the values being set in the map owner struct is the program type, and since the code did not resolve the prog type for fext programs, the map owner type would be set to PROG_TYPE_EXT and subsequent loading of programs of the target type into the map would fail. This bug is seen in particular for XDP programs that are loaded as PROG_TYPE_EXT using libxdp; these cannot insert programs into devmaps and cpumaps because the check fails as described above. Fix the bug by resolving the fext program type to its target program type as elsewhere in the verifier. This requires constifying the parameter of resolve_prog_type() to avoid a compiler warning from the new call site. v3: - Add Yonghong's ACK Fixes: f45d5b6 ("bpf: generalise tail call map compatibility check") Acked-by: Yonghong Song <yhs@fb.com> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
|
Upstream branch: 4121d44 |
…program This adds a simple test for inserting an XDP program into a cpumap that is "owned" by an XDP program that was loaded as PROG_TYPE_EXT (as libxdp does). Prior to the kernel fix this would fail because the map type ownership would be set to PROG_TYPE_EXT instead of being resolved to PROG_TYPE_XDP. v5: - Fix a few nits from Andrii, add his ACK v4: - Use skeletons for selftest v3: - Update comment to better explain the cause - Add Yonghong's ACK Acked-by: Yonghong Song <yhs@fb.com> Acked-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
kernel-patches-bot
force-pushed
the
series/702768=>bpf
branch
from
b58f8e0
to
cc65b32
Compare
kernel-patches-bot
force-pushed
the
bpf_base
branch
from
6e3baff
to
647bc30
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=704610 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Resolve fext program type when checking map compatibility
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=704318