selftests/bpf: Fix map_kptr test. #4598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 1f5dfcc |
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
d3adaeb
to
9fb858b
Compare
|
Upstream branch: 213aacb |
kernel-patches-bot
force-pushed
the
series/721900=>bpf-next
branch
from
b946c39
to
5719b53
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
9fb858b
to
3e7d3dd
Compare
|
Upstream branch: 5e53e5c |
The compiler is optimizing out majority of unref_ptr read/writes, so the test wasn't testing much. For example, one could delete '__kptr' tag from 'struct prog_test_ref_kfunc __kptr *unref_ptr;' and the test would still "pass". Convert it to volatile stores. Confirmed by comparing bpf asm before/after. Fixes: 2cbc469 ("selftests/bpf: Add C tests for kptr") Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Stanislav Fomichev <sdf@google.com> Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
kernel-patches-bot
force-pushed
the
series/721900=>bpf-next
branch
from
5719b53
to
de2cbdf
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
3e7d3dd
to
a3600c4
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=721900 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix map_kptr test.
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=721900