Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash #4840

Closed
wants to merge 5 commits into from
Closed

XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash #4840

wants to merge 5 commits into from

Conversation

kernel-patches-bot
Copy link

Pull request for series with
subject: XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=734748

@kernel-patches-bot
Copy link
Author

Upstream branch: a6f6a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=734748
version: 1

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/netdevbpf/list/?series=734748
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Applying: xdp: rss hash types representation
Applying: igc: bpf_xdp_metadata_rx_hash return xdp rss hash type
Patch failed at 0002 igc: bpf_xdp_metadata_rx_hash return xdp rss hash type
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".'
  stderr: 'error: sha1 information is lacking or useless (drivers/net/ethernet/intel/igc/igc_main.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch'

conflict:

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=734748 expired. Closing PR.

@kernel-patches-bot
Copy link
Author

Upstream branch: a6f6a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=735092
version: 1

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/netdevbpf/list/?series=735092
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Applying: xdp: rss hash types representation
Applying: igc: bpf_xdp_metadata_rx_hash return xdp rss hash type
Patch failed at 0002 igc: bpf_xdp_metadata_rx_hash return xdp rss hash type
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".'
  stderr: 'error: sha1 information is lacking or useless (drivers/net/ethernet/intel/igc/igc_main.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch'

conflict:

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=735092 expired. Closing PR.

@kernel-patches-bot
Copy link
Author

Upstream branch: a6f6a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=735513
version: 1

@kernel-patches-bot
Copy link
Author

Upstream branch: a6f6a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=735513
version: 1

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=735513 expired. Closing PR.

@kernel-patches-bot
Copy link
Author

Upstream branch: a6f6a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=735864
version: 4

@kernel-patches-bot
Copy link
Author

Upstream branch: a6f6a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=735957
version: 5

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=735957 expired. Closing PR.

@netoptimizer
xdp: rss hash types representation
ed8824c 
The RSS hash type specifies what portion of packet data NIC hardware used
when calculating RSS hash value. The RSS types are focused on Internet
traffic protocols at OSI layers L3 and L4. L2 (e.g. ARP) often get hash
value zero and no RSS type. For L3 focused on IPv4 vs. IPv6, and L4
primarily TCP vs UDP, but some hardware supports SCTP.

Hardware RSS types are differently encoded for each hardware NIC. Most
hardware represent RSS hash type as a number. Determining L3 vs L4 often
requires a mapping table as there often isn't a pattern or sorting
according to ISO layer.

The patch introduce a XDP RSS hash type (enum xdp_rss_hash_type) that
contain combinations to be used by drivers, which gets build up with bits
from enum xdp_rss_type_bits. Both enum xdp_rss_type_bits and
xdp_rss_hash_type get exposed to BPF via BTF, and it is up to the
BPF-programmer to match using these defines.

This proposal change the kfunc API bpf_xdp_metadata_rx_hash() adding
a pointer value argument for provide the RSS hash type.

Change function signature for all xmo_rx_hash calls in drivers to make it
compile. The RSS type implementations for each driver comes as separate
patches.

Fixes: 3d76a4d ("bpf: XDP metadata RX kfuncs")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
@netoptimizer
mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
23606a7 
Update API for bpf_xdp_metadata_rx_hash() with arg for xdp rss hash type
via mapping table.

The mlx5 hardware can also identify and RSS hash IPSEC.  This indicate
hash includes SPI (Security Parameters Index) as part of IPSEC hash.

Extend xdp core enum xdp_rss_hash_type with IPSEC hash type.

Fixes: bc8d405 ("net/mlx5e: Support RX XDP metadata")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
@netoptimizer
veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
ca2f036 
Update API for bpf_xdp_metadata_rx_hash() with arg for xdp rss hash type.

The veth driver currently only support XDP-hints based on SKB code path.
The SKB have lost information about the RSS hash type, by compressing
the information down to a single bitfield skb->l4_hash, that only knows
if this was a L4 hash value.

In preparation for veth, the xdp_rss_hash_type have an L4 indication
bit that allow us to return a meaningful L4 indication when working
with SKB based packets.

Fixes: 306531f ("veth: Support RX XDP metadata")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
@netoptimizer
mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
ac8b8c3 
Update API for bpf_xdp_metadata_rx_hash() with arg for xdp rss hash type
via matching indiviual Completion Queue Entry (CQE) status bits.

Fixes: ab46182 ("net/mlx4_en: Support RX XDP metadata")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
@netoptimizer
selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg
f66d09d 
Update BPF selftests to use the new RSS type argument for kfunc
bpf_xdp_metadata_rx_hash.

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
@kernel-patches-bot
Copy link
Author

Upstream branch: 738a96c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=736141
version: 6

@kernel-patches-daemon-bpf
Copy link

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=736141 expired. Closing PR.

@kernel-patches-daemon-bpf kernel-patches-daemon-bpf bot deleted the series/734748=>bpf branch April 6, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bpf changes-requested V6
Projects
None yet
Milestone
No milestone
2 participants
@kernel-patches-bot @netoptimizer