kallsyms: Disable preemption for find_kallsyms_symbol_value #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 16b7c97 |
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
80be3d8
to
e83994e
Compare
|
Upstream branch: f6a6a5a |
kernel-patches-bot
force-pushed
the
series/736571=>bpf-next
branch
from
8a7434f
to
73142cb
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
e83994e
to
f1d7c36
Compare
|
Upstream branch: 8fc59c2 |
kernel-patches-bot
force-pushed
the
series/736571=>bpf-next
branch
from
73142cb
to
d0d4a2c
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
f1d7c36
to
34003fc
Compare
Artem reported suspicious RCU usage [1]. The reason is that verifier calls find_kallsyms_symbol_value with preemption enabled which will trigger suspicious RCU usage warning in rcu_dereference_sched call. Disabling preemption in find_kallsyms_symbol_value and adding __find_kallsyms_symbol_value function. Fixes: 31bf1db ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules") [1] https://lore.kernel.org/bpf/ZBrPMkv8YVRiWwCR@samus.usersys.redhat.com/ Reported-by: Artem Savkov <asavkov@redhat.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com> Tested-by: Artem Savkov <asavkov@redhat.com>
|
Upstream branch: e8f59d8 |
kernel-patches-bot
force-pushed
the
series/736571=>bpf-next
branch
from
d0d4a2c
to
74925c4
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
34003fc
to
8937298
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=736571 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: kallsyms: Disable preemption for find_kallsyms_symbol_value
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=736571