Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Return -ENOTSUPP if callbacks are not allowed in non-JITed programs #6195

Closed

Conversation

kernel-patches-daemon-bpf[bot]
Copy link

Pull request for series with
subject: bpf: Return -ENOTSUPP if callbacks are not allowed in non-JITed programs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 5abde62
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 5abde62
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 9c9d9f6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 2ab1efa
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a640de4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: b456005
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: b456005
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 417fa6d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

If CONFIG_BPF_JIT_ALWAYS_ON is not set and bpf_jit_enable is 0, there
exist 6 failed tests.

  [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable
  [root@linux bpf]# ./test_verifier | grep FAIL
  #107/p inline simple bpf_loop call FAIL
  #108/p don't inline bpf_loop call, flags non-zero FAIL
  #109/p don't inline bpf_loop call, callback non-constant FAIL
  #110/p bpf_loop_inline and a dead func FAIL
  #111/p bpf_loop_inline stack locations for loop vars FAIL
  #112/p inline bpf_loop call in a big program FAIL
  Summary: 505 PASSED, 266 SKIPPED, 6 FAILED

The test log shows that callbacks are not allowed in non-JITed programs,
interpreter doesn't support them yet, thus these tests should be skipped
if jit is disabled, just return -ENOTSUPP instead of -EINVAL for pseudo
calls in fixup_call_args().

With this patch:

  [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable
  [root@linux bpf]# ./test_verifier | grep FAIL
  Summary: 505 PASSED, 272 SKIPPED, 0 FAILED

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: f8506c5
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=812794 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
0 participants