-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: Return -ENOTSUPP if callbacks are not allowed in non-JITed programs #6195
Conversation
Upstream branch: 5abde62 |
b324dbc
to
559bbcf
Compare
Upstream branch: 5abde62 |
945d5a3
to
a573f5c
Compare
559bbcf
to
5c1840a
Compare
Upstream branch: 9c9d9f6 |
a573f5c
to
455f887
Compare
5c1840a
to
bebfc23
Compare
Upstream branch: 2ab1efa |
455f887
to
f1e5376
Compare
bebfc23
to
9ae8f30
Compare
Upstream branch: a640de4 |
f1e5376
to
955cd3f
Compare
9ae8f30
to
aaa9b91
Compare
Upstream branch: b456005 |
955cd3f
to
c9d4bfa
Compare
aaa9b91
to
4b58dd5
Compare
Upstream branch: b456005 |
c9d4bfa
to
e411166
Compare
4b58dd5
to
cfa6261
Compare
Upstream branch: 417fa6d |
e411166
to
fbc58b8
Compare
cfa6261
to
49fe638
Compare
If CONFIG_BPF_JIT_ALWAYS_ON is not set and bpf_jit_enable is 0, there exist 6 failed tests. [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable [root@linux bpf]# ./test_verifier | grep FAIL #107/p inline simple bpf_loop call FAIL #108/p don't inline bpf_loop call, flags non-zero FAIL #109/p don't inline bpf_loop call, callback non-constant FAIL #110/p bpf_loop_inline and a dead func FAIL #111/p bpf_loop_inline stack locations for loop vars FAIL #112/p inline bpf_loop call in a big program FAIL Summary: 505 PASSED, 266 SKIPPED, 6 FAILED The test log shows that callbacks are not allowed in non-JITed programs, interpreter doesn't support them yet, thus these tests should be skipped if jit is disabled, just return -ENOTSUPP instead of -EINVAL for pseudo calls in fixup_call_args(). With this patch: [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable [root@linux bpf]# ./test_verifier | grep FAIL Summary: 505 PASSED, 272 SKIPPED, 0 FAILED Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Upstream branch: f8506c5 |
fbc58b8
to
91aafb1
Compare
49fe638
to
0c14840
Compare
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=812794 expired. Closing PR. |
Pull request for series with
subject: bpf: Return -ENOTSUPP if callbacks are not allowed in non-JITed programs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=812794