fix array-index-out-of-bounds in bpf_prog_select_runtime #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
The error indicates that the verifier is letting through a program with a stack depth bigger than 512. This is due to the verifier not checking the stack depth after instruction rewrites are perfomed. For example, the MAY_GOTO instruction adds 8 bytes to the stack, which means that if the stack at the moment was already 512 bytes it would overflow after rewriting the instruction. The fix involves adding a stack depth check after all instruction rewrites are performed. Reported-by: syzbot+d2a2c639d03ac200a4f1@syzkaller.appspotmail.com Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
|
Upstream branch: a9e7715 |
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=850506 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: fix array-index-out-of-bounds in bpf_prog_select_runtime
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=850506