bpf: avoid uninitialized value in BPF_CORE_READ_BITFIELD #6986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 329a672 |
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=851141 expired. Closing PR. |
|
Upstream branch: 7e2c7a3 |
kernel-patches-daemon-bpf
bot
added
new
V2
and removed
changes-requested
V1
V1-ci-pass
labels
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851141=>bpf-next
branch
from
63559bf
to
81ededa
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
606f72a
to
041b1be
Compare
|
Upstream branch: e612b5c |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851141=>bpf-next
branch
from
81ededa
to
066d65c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
041b1be
to
63334d2
Compare
[Changes from V1:
- Use a default branch in the switch statement to initialize `val'.]
GCC warns that `val' may be used uninitialized in the
BPF_CRE_READ_BITFIELD macro, defined in bpf_core_read.h as:
[...]
unsigned long long val; \
[...] \
switch (__CORE_RELO(s, field, BYTE_SIZE)) { \
case 1: val = *(const unsigned char *)p; break; \
case 2: val = *(const unsigned short *)p; break; \
case 4: val = *(const unsigned int *)p; break; \
case 8: val = *(const unsigned long long *)p; break; \
} \
[...]
val; \
} \
This patch adds a default entry in the switch statement that sets
`val' to zero in order to avoid the warning, and random values to be
used in case __builtin_preserve_field_info returns unexpected values
for BPF_FIELD_BYTE_SIZE.
Tested in bpf-next master.
No regressions.
Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Cc: david.faust@oracle.com
Cc: cupertino.miranda@oracle.com
Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: Yonghong Song <yonghong.song@linux.dev>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
|
Upstream branch: 911edc6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851141=>bpf-next
branch
from
066d65c
to
77d88fe
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
63334d2
to
2a4c29b
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=851511 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: avoid uninitialized value in BPF_CORE_READ_BITFIELD
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=851141