Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable BPF programs to declare arrays of kptr, bpf_rb_root, and bpf_list_head. #6996

Closed
wants to merge 10 commits into from
Closed

Enable BPF programs to declare arrays of kptr, bpf_rb_root, and bpf_list_head. #6996

wants to merge 10 commits into from

Conversation

kernel-patches-daemon-bpf[bot]
Copy link

Pull request for series with
subject: Enable BPF programs to declare arrays of kptr, bpf_rb_root, and bpf_list_head.
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 7e2c7a3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: e612b5c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 911edc6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 0093670
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: cbe35ad
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 0d03a4d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: fcd1ed8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=851439
version: 4

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: fcd1ed8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=852089
version: 5

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 531876c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=855436
version: 7

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 96a27ee
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=855436
version: 7

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: ce5249b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=855436
version: 7

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: ec1249d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=855436
version: 7

@ThinkerYzu1
bpf: Remove unnecessary checks on the offset of btf_field.
65ff622 
reg_find_field_offset() always return a btf_field with a matching offset
value. Checking the offset of the returned btf_field is unnecessary.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
bpf: Remove unnecessary call to btf_field_type_size().
56594a7 
field->size has been initialized by bpf_parse_fields() with the value
returned by btf_field_type_size(). Use it instead of calling
btf_field_type_size() again.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
bpf: refactor btf_find_struct_field() and btf_find_datasec_var().
74356c3 
Move common code of the two functions to btf_find_field_one().

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
bpf: create repeated fields for arrays.
b4e5f01 
The verifier uses field information for certain special types, such as
kptr, rbtree root, and list head. These types are treated
differently. However, we did not previously support these types in
arrays. This update examines arrays and duplicates field information the
same number of times as the length of the array if the element type is one
of the special types.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
bpf: look into the types of the fields of a struct type recursively.
1ba2069 
The verifier has field information for specific special types, such as
kptr, rbtree root, and list head. These types are handled
differently. However, we did not previously examine the types of fields of
a struct type variable. Field information records were not generated for
the kptrs, rbtree roots, and linked_list heads that are not located at the
outermost struct type of a variable.

For example,

  struct A {
    struct task_struct __kptr * task;
  };

  struct B {
    struct A mem_a;
  }

  struct B var_b;

It did not examine "struct A" so as not to generate field information for
the kptr in "struct A" for "var_b".

This patch enables BPF programs to define fields of these special types in
a struct type other than the direct type of a variable or in a struct type
that is the type of a field in the value type of a map.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
bpf: limit the number of levels of a nested struct type.
fd09dcd 
Limit the number of levels looking into struct types to avoid running out
of stack space.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
selftests/bpf: Test kptr arrays and kptrs in nested struct fields.
f87f798 
Make sure that BPF programs can declare global kptr arrays and kptr fields
in struct types that is the type of a global variable or the type of a
nested descendant field in a global variable.

An array with only one element is special case, that it treats the element
like a non-array kptr field. Nested arrays are also tested to ensure they
are handled properly.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 49784c7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=855436
version: 7

@ThinkerYzu1
selftests/bpf: Test global bpf_rb_root arrays and fields in nested st…
70284ec 
…ruct types.

Make sure global arrays of bpf_rb_root and fields of bpf_rb_root in nested
struct types work correctly.

Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@ThinkerYzu1
selftests/bpf: Test global bpf_list_head arrays.
1b2b0e9 
Make sure global arrays of bpf_list_heads and fields of bpf_list_heads in
nested struct types work correctly.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
@kernel-patches-daemon-bpf
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=855436 irrelevant now. Closing PR.

@kernel-patches-daemon-bpf kernel-patches-daemon-bpf bot deleted the series/843029=>bpf-next branch June 4, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accepted bpf-next V7-ci-pass V7
Projects
None yet
Milestone
No milestone
1 participant
@ThinkerYzu1