libbpf: keep FD_CLOEXEC flag when dup()'ing FD #7117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: fbe3e84 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a0331be
to
35bd8d8
Compare
|
Upstream branch: f088cab |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/857152=>bpf-next
branch
from
305b512
to
6fc756c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
35bd8d8
to
6380a82
Compare
|
Upstream branch: 46253c4 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/857152=>bpf-next
branch
from
6fc756c
to
fffbecd
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
6380a82
to
214f651
Compare
Make sure to preserve and/or enforce FD_CLOEXEC flag on duped FDs. Use dup3() with O_CLOEXEC flag for that. Without this fix libbpf effectively clears FD_CLOEXEC flag on each of BPF map/prog FD, which is definitely not the right or expected behavior. Reported-by: Lennart Poettering <lennart@poettering.net> Fixes: bc308d0 ("libbpf: call dup2() syscall directly") Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Acked-by: Jiri Olsa <jolsa@kernel.org>
|
Upstream branch: 3f8fde3 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/857152=>bpf-next
branch
from
fffbecd
to
2dd48ce
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
214f651
to
c939103
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=857152 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: keep FD_CLOEXEC flag when dup()'ing FD
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=857152