Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s service-account tempfile creation #24

Merged
merged 1 commit into from Jul 21, 2020

Conversation

gctucker
Copy link
Contributor

The temporary file for the service-account key is created within a
temporary directory created by the "kernelci" user, but the
"buildslave" user doesn't have write permissions there. Fix that by
first creating it with the default "kernelci" user and then change
ownership to "buildslave".

Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com

The temporary file for the service-account key is created within a
temporary directory created by the "kernelci" user, but the
"buildslave" user doesn't have write permissions there.  Fix that by
first creating it with the default "kernelci" user and then change
ownership to "buildslave".

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
@gctucker gctucker requested review from khilman and a team July 21, 2020 06:37
@gctucker gctucker added this to In progress in KernelCI 2020-Q3 via automation Jul 21, 2020
@gctucker gctucker added this to In Progress in KernelCI project board via automation Jul 21, 2020
Copy link
Contributor

@khilman khilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I wasn't sure how to do this correctly. Thanks!

@gctucker gctucker merged commit 3f94a2c into kernelci:master Jul 21, 2020
KernelCI project board automation moved this from In Progress to Done Jul 21, 2020
KernelCI 2020-Q3 automation moved this from In progress to Done Jul 21, 2020
@gctucker gctucker deleted the k8s-tempfile-fixup branch July 21, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants