api.main: handle new Node path format in node submission #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a /-separated path string for Node paths instead of a list of
strings, we can encode whether a Node is a leaf node or an intermediate
node in a tree by ending the path string with a trailing slash
character ('/') for intermediate nodes.
Implement the appropriate checks and logic in the node submission
endpoints. For single nodes, adapt the path string of the parent
node. For node trees, normalize the paths for the whole tree, adding
trailing slashes when needed for all intermediate nodes.
Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
hardboprobot
added
the
staging-skip
The Node path is now encoded using a regular /-separated path string instead of a list of strings. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
The Node path is now encoded using a regular /-separated path string instead of a list of strings. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Required after:
api.main: handle new Node path format in node submission
Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
|
LGTM. I'll mark it approved once we successfully test this on staging with all the related PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a /-separated path string for Node paths instead of a list of strings, we can encode whether a Node is a leaf node or an intermediate node in a tree by ending the path string with a trailing slash character ('/') for intermediate nodes.
Implement the appropriate checks and logic in the node submission endpoints. For single nodes, adapt the path string of the parent node. For node trees, normalize the paths for the whole tree, adding trailing slashes when needed for all intermediate nodes.
DEPENDS ON kernelci/kernelci-core#2466, the unit tests will fail until that PR is merged
NOTE These changes require running the DB migration script included.