report/templates/bisect: add disclaimer paragraph

[gctucker]

Add a paragraph to the bisection report email template to explain that
this is the result of an automated bisection so there may not be
anything wrong with the "breaking" commit it has found.

Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com

[gctucker]

What the HTML version looks like:

[ana]

My 2cents: I'd change the "take a pinch of salt" with something more direct for people not knowing this idiom: "Please, be patient, this feature is experimental"

[gctucker]

It's not so much to warn about false positives, but also because of the nature of kernel problems. In many cases, the bisection finds a perfectly valid commit that turned a hidden issue somewhere else into a visible failure.

[broonie]

I agree with Ana, something that's clearer for people who's English is a bit weaker would be better. You could probably just delete the "please take this with a pinch of salt" and the rest should be fine.

[gctucker]

Alright I'll let people add some salt themselves if they want to :)

[gctucker]

OK got a report from my test branch:

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* This automated bisection report was sent to you on the basis  *
* that you may be involved with the breaking commit it has      *
* found.  No manual investigation has been done to verify it,   *
* and the root cause of the problem may be somewhere else.      *
* Hope this helps!                                              *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

Bisection result for gtucker/kernelci-test (kernelci-test-087-8-g86c029f48d8f) on qemu

  Good:       ea67b0ffadd1 HACK disable all{yes,no,mod}config and tinyconfig
  Bad:        86c029f48d8f NOISE Special cases aren't special enough...
  Found:      13fc8e8d9f9d BREAK panic on QEMU

Details:
  Good:       https://staging.kernelci.org/boot/all/job/gtucker/branch/kernelci-test/kernel/kernelci-test-087/
  Bad:        https://staging.kernelci.org/boot/all/job/gtucker/branch/kernelci-test/kernel/kernelci-test-087-8-g86c029f48d8f/

Checks:
  revert:     PASS
  verify:     PASS

Parameters:
  Tree:       gtucker
  URL:        https://gitlab.collabora.com/gtucker/linux.git
  Branch:     kernelci-test
  Target:     qemu
  Lab:        lab-collabora-dev
  Config:     defconfig
  Plan:       boot

Breaking commit found:

-------------------------------------------------------------------------------
commit 13fc8e8d9f9d57203becc4bda787321a00d0f656
Author: Guillaume Tucker <guillaume.tucker@collabora.com>
Date:   Tue Nov 20 13:02:32 2018 +0000

    BREAK panic on QEMU
    
    Cause a panic on purpose on QEMU when trying to boot with an
    initramfs.
    
    Tested-by: Bob Tester <guillaume.tucker@gmail.com>
    Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.co.uk>
    Reviewed-by: Some Reviewer <gtucker@collabora.com>
    Link: https://gtucker.io/
    Fixes: 1234567abcdef ("this isn't a real commit")

diff --git a/init/initramfs.c b/init/initramfs.c
index 1c021d5f1400..d6dec4c37ec1 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -10,6 +10,9 @@
 #include <linux/syscalls.h>
 #include <linux/utime.h>
 #include <linux/file.h>
+#if 1
+#include <linux/of_fdt.h>
+#endif
 
 static ssize_t __init xwrite(int fd, const char *p, size_t count)
 {
@@ -609,6 +612,16 @@ static int __init populate_rootfs(void)
 	printk(KERN_EMERG "Complex is better than complicated.\n");
 	printk(KERN_EMERG "Flat is better than nested.\n");
 #endif
+
+#if 1
+	{
+		const char *name = of_flat_dt_get_machine_name();
+		if (!strcmp(name, "linux,dummy-virt"))
+			panic("THIS MUST FAIL ON QEMU");
+	}
+
+#endif
+
 	/* If available load the bootloader supplied initrd */
 	if (initrd_start && !IS_ENABLED(CONFIG_INITRAMFS_FORCE)) {
 #ifdef CONFIG_BLK_DEV_RAM
-------------------------------------------------------------------------------


Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [ea67b0ffadd1807878a52aa46dec23e297ac5b77] HACK disable all{yes,no,mod}config and tinyconfig
git bisect good ea67b0ffadd1807878a52aa46dec23e297ac5b77
# bad: [86c029f48d8fc8a9041580a63828e8ff78f4eb5a] NOISE Special cases aren't special enough...
git bisect bad 86c029f48d8fc8a9041580a63828e8ff78f4eb5a
# bad: [13fc8e8d9f9d57203becc4bda787321a00d0f656] BREAK panic on QEMU
git bisect bad 13fc8e8d9f9d57203becc4bda787321a00d0f656
# good: [405c7d9f95a228a39e37f28a127fc5c02b2e6217] NOISE Complex is better than complicated
git bisect good 405c7d9f95a228a39e37f28a127fc5c02b2e6217
# good: [59cfd4b8f28cb571037fa5b5a9f8b1bc6fbe0df0] NOISE Flat is better than nested
git bisect good 59cfd4b8f28cb571037fa5b5a9f8b1bc6fbe0df0
# first bad commit: [13fc8e8d9f9d57203becc4bda787321a00d0f656] BREAK panic on QEMU
-------------------------------------------------------------------------------