This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
T11529 bisection recipients #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a test job running this, with a made-up breaking commit: The important parts from the Jenkins log are: Note: The "bot@kernelci.org" recipient comes from the fact that the bisection job sets it as the git user. I'm not actually entirely sure why it was added here, maybe because the job created a temporary git tag on this commit - I'll try to find out. It's not really an issue, but it's a bit weird. Also we probably don't really want to be sending emails to that address... |
|
LGTM. |
Fix error propagation since the bisection code was moved to a separate function as part of the move to run the job in a Docker container. This is to avoid sending emails when the "verify" check fails. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> Fixes: da83f4f ("bisect.jpl: use Docker")
Automatically add bisection email report recipients based on the breaking commit found. Also still send the report to the list of recipients provided on the command line. If any of the bisection checks failed (verify, revert...) then the report will not be sent to the commit related recipients, only to those provided on the command line. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Set the delay when sending the bisection report email to 60 seconds. This removes the default delay of 1h 5s, so the report will be sent sooner. Keep it greater than 0 to leave the time for the backend to asynchronously store the bisection meta-data before triggering the email report which then uses this data. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to automatically determine the list of recipients for the bisection email reports. If any of the checks failed (verify, revert...) then the report will only be sent to the hard-coded list of recipients set in the Jenkins job like now.
This PR contains a
STAGINGcommit intended to be used on staging to test this feature without actually sending the emails to all the recipients; they are instead only shown in the Jenkins log.