Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-configs.yaml: Add kernel configs for juniper #1352

Merged
merged 1 commit into from Dec 20, 2022

Conversation

nfraprado
Copy link
Contributor

Enable all kernel configs required to get all devices on
mt8183-kukui-jacuzzi-juniper-sku16 probing.

Signed-off-by: Nícolas F. R. A. Prado nfraprado@collabora.com

A lot of these configs are the same as in #1325. After one of the PRs is merged I'll rebase the other to have only the missing ones. I'll also send these configs upstream.

@nuclearcat
Copy link
Collaborator

Can you rebase it please?

Enable all kernel configs required to get all devices on
mt8183-kukui-jacuzzi-juniper-sku16 probing.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@nfraprado
Copy link
Contributor Author

@nuclearcat Rebased. And also dropped CONFIG_SPI_MTK_NOR since it was added by mistake and is needed by mt8192, but not mt8183.

I also sent the defconfig changes upstream: https://lore.kernel.org/all/20221108232228.1177199-1-nfraprado@collabora.com

And the sound configs

       - 'CONFIG_SND_SOC_MT8183=y'
       - 'CONFIG_SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y'

can be changed to modules after https://lore.kernel.org/all/20221107160437.740353-1-nfraprado@collabora.com is merged.

@nfraprado
Copy link
Contributor Author

The defconfig changes were merged to the mediatek tree, and should find their way to mainline for v6.2: https://lore.kernel.org/linux-mediatek/610edfca-0a3a-fd41-5208-71978866be4f@gmail.com/

But I think adding these configs to the fragment still makes sense so we can test juniper with older stable kernels.

@nuclearcat nuclearcat self-assigned this Nov 29, 2022
Copy link
Collaborator

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment seems device is broken and doesnt boot in mainline: https://storage.staging.kernelci.org/kernelci/staging-mainline/staging-mainline-20221130.0/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/baseline-mt8183-kukui-jacuzzi-juniper-sku16.html
It doesnt boot in -next either: https://storage.staging.kernelci.org/kernelci/staging-next/staging-next-20221129.1/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/baseline-mt8183-kukui-jacuzzi-juniper-sku16.html

I checked also stable, but it doesn't look like options are working, i dont see any ALSA devices detected for example.

Also i think there is certain number of warnings appeared after enabling audio driver, for example:

 1371 16:46:54.629362  <3>[   11.975754] debugfs: Directory '11220000.audio-controller:mt8183-afe-pcm' with parent 'mt8183_mt6358_ts3a227_max98357' already present!
 1372 16:46:54.646699  <3>[   11.992695] mt8183_mt6358_ts3a227 mt8183-sound: ASoC: driver name too long 'mt8183_mt6358_ts3a227_max98357' -> 'mt8183_mt6358_t'
 1373 16:46:54.653364  <3>[   12.005202] debugfs: File 'Playback' in directory 'dapm' already present!
 1374 16:46:54.659919  <3>[   12.012287] debugfs: File 'Capture' in directory 'dapm' already present!

@nfraprado
Copy link
Contributor Author

Indeed looks like mt8183-jacuzzi-juniper is hanging during boot on next right now. From a quick check, seems to be related to the GPU, since disabling the GPU node gets it booting fine again. I know there were some recent clock and DVFS changes for the GPU on mt8183, so maybe some of that is causing issues here. I'll investigate it shortly so we can get this out of the way. (To be clear the issue is unrelated to this PR, but of course we need the machine working again before we can test and merge this PR)

Regarding the audio warnings, the driver name too long is something that needs to be taken care of before upstreaming the UCM for this machine, and I can do that soon, but otherwise is not an issue. Since this PR enables a bunch of the devices on the machine, it's somewhat expected that new warnings and errors will appear. And as long as they don't make the machine unbootable/unusable, by having the drivers be frequently tested, we can work on fixing any warnings/errors upstream and see them disappearing from these logs over time.

@nfraprado
Copy link
Contributor Author

The boot hang issue on mt8183 is due to a series being only partially applied. I've replied to the missing patch so soon it should be applied and the issue fixed.

@nuclearcat
Copy link
Collaborator

Device is booting.
https://storage.staging.kernelci.org/kernelci/staging-next/staging-next-20221219.2/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/baseline-mt8183-kukui-jacuzzi-juniper-sku16.html

One of devices i can see properly detected:


[ 1388] 10:06:29.080177  <6>[   14.253299] ALSA device list:
[ 1389] 10:06:29.086606  <6>[   14.256586]   #0: mt8183_mt6358_ts3a227_max98357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants