Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-configs-cip.yaml: Disable arm64 builds for 4.4-cip #1362

Merged
merged 1 commit into from Aug 18, 2022

Conversation

fbezdeka
Copy link
Contributor

arm64 was out of scope for the 4.4 series. Disabling it save some
resources and silences arm64 related testing issues.

Signed-off-by: Florian Bezdeka florian.bezdeka@siemens.com

arm64 was out of scope for the 4.4 series. Disabling it save some
resources and silences arm64 related testing issues.

Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
@fbezdeka
Copy link
Contributor Author

@aliceinwire, according to last CIP meeting I'm trying to disable arm64 builds for 4.4-cip only. Let's see what the test run on staging reports...

@patersonc
Copy link
Contributor

I'm guessing we need to trigger a build manually on staging for the cip 4.4 kernel?

Latest staging build was a couple of weeks ago: https://staging.kernelci.org/job/cip/

@aliceinwire aliceinwire added the cip cip related issues label Aug 12, 2022
@aliceinwire
Copy link
Member

aliceinwire commented Aug 15, 2022

started cip_4.4 staging test
The results will appear here: https://staging.kernelci.org/job/cip/

@fbezdeka
Copy link
Contributor Author

Thanks for starting the build.

Seems we have 5 findings now:

@aliceinwire
Copy link
Member

looks like arm64 is correctly disabled.
@fbezdeka please don't mix pull request off topic discussion here.
open a new issue or pr for that problems.

@aliceinwire
Copy link
Member

@gctucker can you check this?

@gctucker
Copy link
Contributor

It appears to be working as expected according to the results on the web dashboard. I'm actually slightly surprised as it's the first time we use filters this way, normally build configurations are defined "positively" with a set of configs to build for a particular branch rather than "negatively" with a full config with a filter to remove some.

But I've double-checked that locally using this command:

$ ./kci_build list_kernel_configs --build-config=cip_4.4 --kdir=/home/gtucker/src/linux | sort > configs-4.4.txt

First with the actual linux-4.4.y branch checked out in the linux kernel tree, then the exact same command but with linux-4.9 (which doesn't normally happen in production but that's a detail). Here's the interesting part of the diff:

$ diff -u configs-4.4.txt configs-4.9.txt 
--- configs-4.4.txt	2022-08-18 19:26:54.040003265 +0200
+++ configs-4.9.txt	2022-08-18 19:30:49.648003732 +0200
@@ -9,16 +9,22 @@
 arc tinyconfig gcc-10
 arc vdk_hs38_defconfig gcc-10
 arc vdk_hs38_smp_defconfig gcc-10
+arc zebu_hs_defconfig gcc-10
+arc zebu_hs_smp_defconfig gcc-10
+arm64 allnoconfig gcc-10
+arm64 defconfig gcc-10
+arm64 tinyconfig gcc-10
 arm acs5k_defconfig gcc-10
 arm acs5k_tiny_defconfig gcc-10
 arm allnoconfig gcc-10
 arm am200epdkit_defconfig gcc-10

The arm64 configs are present with 4.9 but not with 4.4. So the filter is working as expected. Nice.

@gctucker gctucker merged commit 6155815 into kernelci:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cip cip related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants