More utility functions for the kernelci-core api helper #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
added
the
staging-skip
a-wai
reviewed
Feb 19, 2024
hardboprobot
force-pushed
the
rcn-add-utils
branch
from
ec7a098
to
b30d9dd
Compare
a-wai
approved these changes
Feb 20, 2024
hardboprobot
force-pushed
the
rcn-add-utils
branch
from
b30d9dd
to
a434010
Compare
|
Additional change: Update the |
hardboprobot
force-pushed
the
rcn-add-utils
branch
from
124e397
to
965a2cd
Compare
|
TODO: Update unit tests |
Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Allow it to take the node parameter either as a Node object, as a concrete Node submodel object or as a dict. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
This function is meant to be used by code issuing API requests (such as a pipeline service) to turn node dicts into objects with resolved references to linked nodes. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Since I don't think we can use use the mypy pydantic plugin (https://docs.pydantic.dev/latest/integrations/mypy/) unless we're using the latest version of pydantic, I set the recommended mypy flags from that page. The purpose is to fix certain wrong mypy assumptions over pydantic models that were causing the checks to fail for kernelci.api.helper. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Make this function create the regression from the two nodes that define the breaking point (the fail node and the previous pass node) and then submit it. This abstracts all the model details and the logic behind the regression generation away from the user code. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
hardboprobot
force-pushed
the
rcn-add-utils
branch
4 times, most recently
from
688beee
to
395284a
Compare
Adapt the test and related mock to test the new submit_regression helper logic (regression generation and submission) against an expected result. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
hardboprobot
force-pushed
the
rcn-add-utils
branch
from
395284a
to
fb2556e
Compare
This was referenced Feb 23, 2024
JenySadadia
reviewed
Feb 29, 2024
|
Do we still need this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_test_suite(): function to tell if a Test node represents a test case or a test suite, as we don't have this information in the models yetget_node_obj(): returns a node dict as a proper object, optionally with resolved links to nodes also fetched as objects.