Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running discoverable devices probe kselftest #2577

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nfraprado
Copy link
Contributor

Do the setup needed to be able to run the discoverable devices probe kselftest in KernelCI. This involves adding a missing dependency to the kselftest rootfs, deploying additional files used by the test, and exposing a newly introduced parameter to allow passing parameters to kselftests.

This depends on Linaro/test-definitions#511.

Add the files from the platform-test-parameters repository to the
kselftest rootfs. They will be used by the discoverable devices probe
kselftest.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Add the python3-yaml package to the kselftest rootfs as it is a
dependency for the discoverable devices probe kselftest.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
As recently introduced upstream in
Linaro/test-definitions#511, the ENV parameter
in the LAVA kselftest runner provides a way to pass parameters to
kselftests through environment variables, as documented in [1]. Add it
to the template so it can be used in job definitions.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/kselftest/runner.sh?h=v6.10-rc3#n61

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@nfraprado nfraprado added the staging-skip Don't test automatically on staging.kernelci.org label Jun 13, 2024
nfraprado added a commit to nfraprado/kernelci-pipeline that referenced this pull request Jun 13, 2024
Enable the discoverable devices probe kselftest. It relies on
platform-specific files to parametrize the test which are stored in
https://github.com/kernelci/platform-test-parameters and deployed to the
kselftest rootfs.

The path to the platform specific files is passed through the kselftest
env variable.

Depends on Linaro/test-definitions#511,
kernelci/kernelci-core#2577
and
https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@pawiecz
Copy link
Contributor

pawiecz commented Jul 4, 2024

Do the setup needed to be able to run the discoverable devices probe kselftest in KernelCI. This involves adding a missing dependency to the kselftest rootfs, deploying additional files used by the test, and exposing a newly introduced parameter to allow passing parameters to kselftests.

Rootfs built successfully, available on https://storage.staging.kernelci.org/rootfs/bookworm-kselftest/20240704.0/arm64/

This depends on Linaro/test-definitions#511.

Latest sync added this change in kernelci/test-definitions

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nfraprado added a commit to nfraprado/kernelci-pipeline that referenced this pull request Jul 5, 2024
Enable the discoverable devices probe kselftest. It relies on
platform-specific files to parametrize the test which are stored in
https://github.com/kernelci/platform-test-parameters and deployed to the
kselftest rootfs.

The path to the platform specific files is passed through the kselftest
env variable.

Depends on Linaro/test-definitions#511,
kernelci/kernelci-core#2577
and
https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@nfraprado nfraprado removed the staging-skip Don't test automatically on staging.kernelci.org label Jul 5, 2024
@nfraprado
Copy link
Contributor Author

I've removed staging-skip label then, so the kselftest template change can be used by kernelci/kernelci-pipeline#642.

nfraprado added a commit to nfraprado/kernelci-pipeline that referenced this pull request Jul 5, 2024
Enable the discoverable devices probe kselftest. It relies on
platform-specific files to parametrize the test which are stored in
https://github.com/kernelci/platform-test-parameters and deployed to the
kselftest rootfs.

The path to the platform specific files is passed through the kselftest
env variable.

Depends on Linaro/test-definitions#511,
kernelci/kernelci-core#2577
and
https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@nuclearcat
Copy link
Collaborator

I will regenerate rootfs with this PR

nfraprado added a commit to nfraprado/kernelci-pipeline that referenced this pull request Jul 18, 2024
Enable the discoverable devices probe kselftest. It relies on
platform-specific files to parametrize the test which are stored in
https://github.com/kernelci/platform-test-parameters and deployed to the
kselftest rootfs.

The path to the platform specific files is passed through the kselftest
env variable.

Depends on Linaro/test-definitions#511,
kernelci/kernelci-core#2577
and
https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants