-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable running discoverable devices probe kselftest #2577
base: main
Are you sure you want to change the base?
Conversation
Add the files from the platform-test-parameters repository to the kselftest rootfs. They will be used by the discoverable devices probe kselftest. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Add the python3-yaml package to the kselftest rootfs as it is a dependency for the discoverable devices probe kselftest. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
As recently introduced upstream in Linaro/test-definitions#511, the ENV parameter in the LAVA kselftest runner provides a way to pass parameters to kselftests through environment variables, as documented in [1]. Add it to the template so it can be used in job definitions. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/kselftest/runner.sh?h=v6.10-rc3#n61 Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Enable the discoverable devices probe kselftest. It relies on platform-specific files to parametrize the test which are stored in https://github.com/kernelci/platform-test-parameters and deployed to the kselftest rootfs. The path to the platform specific files is passed through the kselftest env variable. Depends on Linaro/test-definitions#511, kernelci/kernelci-core#2577 and https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Rootfs built successfully, available on https://storage.staging.kernelci.org/rootfs/bookworm-kselftest/20240704.0/arm64/
Latest sync added this change in kernelci/test-definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable the discoverable devices probe kselftest. It relies on platform-specific files to parametrize the test which are stored in https://github.com/kernelci/platform-test-parameters and deployed to the kselftest rootfs. The path to the platform specific files is passed through the kselftest env variable. Depends on Linaro/test-definitions#511, kernelci/kernelci-core#2577 and https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
I've removed staging-skip label then, so the kselftest template change can be used by kernelci/kernelci-pipeline#642. |
Enable the discoverable devices probe kselftest. It relies on platform-specific files to parametrize the test which are stored in https://github.com/kernelci/platform-test-parameters and deployed to the kselftest rootfs. The path to the platform specific files is passed through the kselftest env variable. Depends on Linaro/test-definitions#511, kernelci/kernelci-core#2577 and https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
I will regenerate rootfs with this PR |
Enable the discoverable devices probe kselftest. It relies on platform-specific files to parametrize the test which are stored in https://github.com/kernelci/platform-test-parameters and deployed to the kselftest rootfs. The path to the platform specific files is passed through the kselftest env variable. Depends on Linaro/test-definitions#511, kernelci/kernelci-core#2577 and https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Do the setup needed to be able to run the discoverable devices probe kselftest in KernelCI. This involves adding a missing dependency to the kselftest rootfs, deploying additional files used by the test, and exposing a newly introduced parameter to allow passing parameters to kselftests.
This depends on Linaro/test-definitions#511.