Implement tree/branch combinations in rules #2613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the most usual counterpart to "allow". Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Currently the rules can only specify allowed/denied trees or branches as a whole, but we lack a way to authorize (or exclude) only a specific branch for a given tree. This change implements tree/branch combination-based rules, by allowing to specify such combinations using the `tree:branch` format under the `tree` and/or `branch` rules. Note: the `:` character has been chosen as a separator because git forbids its use in branch names. Fixes kernelci#2548 Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rules can only specify allowed/denied trees or branches as
a whole, but we lack a way to authorize (or exclude) only a specific
branch for a given tree.
This change implements tree/branch combination-based rules, by allowing
to specify such combinations using the
tree:branchformat under thetreeand/orbranchrules.Note: the
:character has been chosen as a separator because gitforbids its use in branch names.
Fixes #2548