-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-configs.yaml: Enable kselftest-rtc test plan on rk3399-gru-kevin #980
Conversation
rk3399-gru-kevin uses the rtc-cros-ec driver for RTC. Run kselftest-rtc on this device to exercise its driver. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@nfraprado Could you please take a look at the |
Since the whole rtc selftest was timing out, I increased its timeout setting to let all tests run, and with this I was able to see that even though the Lava log with increased timeout: https://lava.collabora.co.uk/scheduler/job/5415176 A patch has been sent upstream changing the timeout setting to allow all tests to run: https://lore.kernel.org/all/20220112165359.3206047-1-nfraprado@collabora.com/ |
@gctucker sure, I'll do that next. I'll also double-check why this timeout increase is needed, since the response on the ML is that it shouldn't be. |
OK thanks. It would be good to also have a GitHub issue in kernelci-project to track this on the kernel bugs board. |
Opened the kernel bug issue at kernelci/kernelci-project#86. I don't have permission to add it to the project/board though. |
Regarding the comparison between the Both tests use the RTC, but their purpose is different. The So what both have in common is working with RTC alarms through use of the The failing test in the rtc kselftest, |
@gctucker I'd say this is ready to be tested on staging and get merged. The failing test case, The fix for the selftest timeout bug has been sent upstream and accepted by the maintainer: https://lore.kernel.org/all/f286a86d-6371-d8bd-6ca9-5f622468d1a4@linuxfoundation.org/. When the fix reaches mainline it will allow the last test case, |
The rk3399-gru-kevin device uses the rtc-cros-ec driver for RTC. This PR adds the kselftest-rtc test on kevin to exercise this driver. The config needed to enable the driver is already part of the arm64 defconfig.
LAVA run: https://lava.collabora.co.uk/scheduler/job/5409783
As can be seen from the LAVA output, the
alarm_alm_set_minute
test, which sets an alarm, is failing with timeout. From a first look it seems like a bug in thertc-cros-ec
driver.