Loading startup-config shows OK despite error detected

[troglobit]

While debugging issue #428 the root cause turned out to be a system error which was not reported back to the console while loading startup-config.

The expected output:

[ OK ] Bootstrapping YANG datastore
[ OK ] Starting Configuration daemon
[ OK ] Starting DHCP/DNS proxy
[ OK ] Starting LED daemon
[ OK ] Verifying SSH host keys
[ OK ] Starting System watchdog daemon
[FAIL] Loading startup-config
[ OK ] Loading failure-config
[ OK ] Update DNS configuration

[troglobit]

Initial analysis shows that sysrepocfg, from the sysrepo project does not return a non-zero exit code when callbacks return a status != SR_ERR_OK in the SR_EV_DONE event.

The documentation states:

SR_EV_DONE: Occurs just after the changes have been successfully committed to the datastore, the subscriber can apply the changes now, but it cannot deny the changes in this phase anymore (any returned errors are just logged and ignored).

We understand this, and agree that it's too late to deny any changes, yet we firmly believe that calling sysrepocfg should return a non-zero exit code if any callback returns non-zero. Because when the rubber hits the road, e.g., calling iproute2 commands, or in this case actually calling adduser, we can run into all sorts of errors/bugs/issues that we cannot prepare for in SR_EV_CHANGE.

A patch to sysrepo has been added to the v2.2.105-kkit branch of sysrepo in kernelkit/sysrepo@49b5580. This will be included in the next patch release of Infix, v24.04.2.