Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function space hashing API to accept an L^p-space similarity instead of corresponding l^p-space similarity #19

Closed
kernelmethod opened this issue Feb 9, 2020 · 0 comments

Comments

@kernelmethod
Copy link
Owner

Currently, we construct a new function-space hash function along the lines of

hashfn = MonteCarloHash(ℓ2, μ, args...; kws...)

This isn't very intuitive; it would make more sense to use L2 instead of ℓ2 since the former is a distance on a function space and the latter works over discrete vectors. ChebHash and MonteCarloHash should be modified so that they accept the function-space similarity that they are using rather than the corresponding discrete-space similarity.

kernelmethod added a commit that referenced this issue Feb 9, 2020
…e similarity rather than a similarity for discrete vectors. This is a fix for issue #19.
@kernelmethod kernelmethod changed the title Change function space hashing API to accept the L^p-space simila/rity instead of corresponding l^p-space similarity Change function space hashing API to accept an L^2-space similarity instead of corresponding l^2-space similarity Feb 9, 2020
@kernelmethod kernelmethod changed the title Change function space hashing API to accept an L^2-space similarity instead of corresponding l^2-space similarity Change function space hashing API to accept an L^p-space similarity instead of corresponding l^p-space similarity Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant