Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for similarity functions #8

Closed
kernelmethod opened this issue Jan 16, 2020 · 3 comments
Closed

Add tests for similarity functions #8

kernelmethod opened this issue Jan 16, 2020 · 3 comments

Comments

@kernelmethod
Copy link
Owner

Currently there are only tests for registering new similarities in test/test_similarities.jl. There should also be some tests to ensure that similarities are computed correctly in the first place.

@kernelmethod
Copy link
Owner Author

As of 3ff9c2f there are currently tests for the following similarities:

  • l1, l2, and lp distance for Vectors
  • L1, L2, and Lp distance for functions
  • cossim for both Vectors and functions
  • jaccard for Sets

This leaves the following similarities to be tested:

  • inner_prod for both Vectors and functions
  • wasserstein_1d for functions (although wasserstein_1d, wasserstein1_1d, and wasserstein2_1d have yet to be implemented).

@kernelmethod
Copy link
Owner Author

Tests for inner_prod were added in 5756eba.

@kernelmethod
Copy link
Owner Author

wasserstein_1d, wasserstein1_1d, and wasserstein2_1d were removed (at least tentatively) in 9ee87cb. I'm closing this issue for now, I'll reopen it if I end up adding more similarities to the package and they suffer the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant