Do not call .setup on Singleton when loading the main lib

[tiagoamaro]

Hi @kernow,

First, thank you very much for this incredible library. It helped me a lot setting up configurable templates for my CMS 🎉

This PR aims to fix the following issue: after I installed Shortcode latest version, I kept reading on my logs the [DEPRECATION] singleton Shortcode.setup warning, which was not true in my case. I barely installed the gem, how I was calling the Shortcode.setup method? 🤔. I didn't know where this was coming, until I checked out the library code.

Based on latest master, I noticed that the Shortcode.setup delegates its call to the .singleton method, which initializes a new instance of the Shortcode object. This will trigger the library default configuration, calling Shortcode.setup or not.

This behavior also makes the Shortcode.setup {} call at the end of the lib/shortcode.rb file unnecessary (

shortcode/lib/shortcode.rb

Line 68 in 8f539c8

Shortcode.setup {}

), removing the deprecation warning for users using the library latest version 😃

Also tested it locally running appraisal rspec, and all tests are green 😄

[coveralls]

Coverage decreased (-0.004%) to 97.794% when pulling fcc2c65 on tiagoamaro:do-not-call-setup-on-initalization into 8f539c8 on kernow:master.

[kernow]

@tiagoamaro thank you for this PR, I've released 2.0.0.pre today which removes the singleton usage from the gem. I'll close the PR as it's covered in the 2.0 branch. If you could test out the prerelease and provide any feedback that would be great.

[tiagoamaro]

@kernow, just ran my test suite against 2.0.0.pre and everything was fine! No more deprecation warnings 🎉