Prevent crash on default color #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made color property non-optional, because the app always crashes if the color is missing. - Added a default system color by default. KRTabBarController: - Reworked conditional in createButtonsStack: second if didn't throw an error, only the first one did + fatalError crashes all builds (including production). Should be better now.
|
That's awesome, |
|
I’m glad to help :) This tab bar looks gorgeous
Can I ask you to add a «hacktoberfest-accepted» label to this PR — this way it’ll be counted for the event.
Thanks
Вторник, 6 октября 2020, 13:08 +03:00 от Kerolles Roshdi ***@***.***>:
Merged #3 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub , or unsubscribe .
--
Igor Chernyshov
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue: #1
KRTabBarItem:
KRTabBarController: