remove OnIceComplete from cgo since it's deprecating in native land, …

…but maintain for the Go interface (issue #5)

cpeerconnection.cc

@@ -121,12 +121,6 @@ class Peer
     cgoOnIceCandidate(goPeerConnection, cgoIC);
   }
 
-  // TODO: OnIceComplete is actually being deprecated in native code.
-  // Should switch to OnIceGatheringState.
-  void OnIceComplete() {
-    cgoOnIceComplete(goPeerConnection);
-  }
-
   void OnIceConnectionChange(
       PeerConnectionInterface::IceConnectionState new_state) {
     // TODO: This may need to be slightly more complicated...

demo/chat/chat.go

@@ -218,6 +218,14 @@ func start(instigator bool) {
 		sdp := pc.LocalDescription().Serialize()
 		signalSend(sdp)
 	}
+	/*
+	pc.OnIceGatheringStateChange = func(state webrtc.IceGatheringState) {
+		fmt.Println("Ice Gathering State:", webrtc.IceGatheringStateString[state])
+		if webrtc.IceGatheringStateComplete == state {
+			// send local description.
+		}
+	}
+	*/
 	// A DataChannel is generated through this callback only when the remote peer
 	// has initiated the creation of the data channel.
 	pc.OnDataChannel = func(channel *data.Channel) {

webrtc.go

@@ -49,7 +49,6 @@ import (
 func init() {
 	SetLoggingVerbosity(3) // Default verbosity.
 }
-
 type (
 	PeerConnectionState int
 	IceGatheringState   int
@@ -336,15 +335,6 @@ func cgoOnIceCandidate(p unsafe.Pointer, cIC C.CGO_IceCandidate) {
 	}
 }
 
-//export cgoOnIceComplete
-func cgoOnIceComplete(p unsafe.Pointer) {
-	INFO.Println("fired OnIceComplete: ", p)
-	pc := (*PeerConnection)(p)
-	if nil != pc.OnIceComplete {
-		pc.OnIceComplete()
-	}
-}
-
 //export cgoOnConnectionStateChange
 func cgoOnConnectionStateChange(p unsafe.Pointer, state PeerConnectionState) {
 	INFO.Println("fired OnConnectionStateChange: ", p)
@@ -361,6 +351,11 @@ func cgoOnIceGatheringStateChange(p unsafe.Pointer, state IceGatheringState) {
 	if nil != pc.OnIceGatheringStateChange {
 		pc.OnIceGatheringStateChange(state)
 	}
+	// Although OnIceComplete is to be deprecated in the native API, and no longer
+	// part of the w3 spec, keeping it for go seems easier for the users.
+	if IceGatheringStateComplete == state && nil != pc.OnIceComplete {
+		pc.OnIceComplete()
+	}
 }
 
 //export cgoOnDataChannel