Update build.sh for repeatable builds of libwebrtc-magic.a #51
Conversation
Modify build.sh to perform a mostly self contained build of webrtc at the tested commit id. Some pre-requisites must be installed before or after a missing tool failure is encountered, e.g. pkg-config on mac or webrtc/src/build/install-build-deps.sh on linux. Tested: linux and mac builds worked from clean virtual machines. Demos and tests passed.
|
Hi arlolra, thank you for the helpful build instructions! I was able to get repeatable builds working from clean checkouts with this patch (Chrome 52 at the same webrtc commit as before). I plan to take a look at Chrome >= 55 sometime soon. |
|
Here's a commit for the recompiled binaries generated from this point, but for security purposes I figure you would prefer not accepting binary patches. So just FYI: cantstopthesignal@f4c11e1 |
| 'webrtcsessiondescriptionfactory.h', | ||
| + 'test/fakeaudiocapturemodule.cc', | ||
| + 'test/fakeaudiocapturemodule.h', | ||
| + 'fakefieldtrial.cc', |
There was a problem hiding this comment.
Let's just add '<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default', to the 'dependencies' like in libjingle_peerconnection_jni instead of providing our own.
There was a problem hiding this comment.
Done -- this worked great, thanks!
| libtool -static -o libwebrtc-magic.a -filelist filelist | ||
| strip -S -x -o libwebrtc-magic.a libwebrtc-magic.a | ||
| else | ||
| ar crs libwebrtc-magic.a $(find . -name '*.o' -not -name '*.main.o' -not -name 'dump_syms_regtest.o') |
There was a problem hiding this comment.
Where's dump_syms_regtest.o coming from?
There was a problem hiding this comment.
Oops, that was left in from a previous attempt. It is not needed in the current way of building
| popd | ||
|
|
||
| echo "Building webrtc ..." | ||
| pushd $WEBRTC_SRC | ||
| ninja -C out/$CONFIG | ||
| export GYP_DEFINES="include_tests=0 include_examples=0" | ||
| python webrtc/build/gyp_webrtc webrtc/api/api.gyp || exit 1 |
There was a problem hiding this comment.
Ah right, I forgot this change results in the Undefined symbols for ... webrtc::field_trial::FindFullName. Sorry :(
There was a problem hiding this comment.
No problem!
I imagine that'll be slightly more involved, but looking forward to seeing what you come up with :) |
1. Remove dump_syms_regtest.o reference 2. Add field_trial_default dependency instead of creating a new cc file
| popd | ||
|
|
||
| echo "Building webrtc ..." | ||
| pushd $WEBRTC_SRC | ||
| ninja -C out/$CONFIG | ||
| export GYP_DEFINES="include_tests=0 include_examples=0" | ||
| python webrtc/build/gyp_webrtc webrtc/api/api.gyp || exit 1 |
There was a problem hiding this comment.
No problem!
| 'webrtcsessiondescriptionfactory.h', | ||
| + 'test/fakeaudiocapturemodule.cc', | ||
| + 'test/fakeaudiocapturemodule.h', | ||
| + 'fakefieldtrial.cc', |
There was a problem hiding this comment.
Done -- this worked great, thanks!
|
Great, thanks! Merged. |
Modify build.sh to perform a mostly self contained build of webrtc at
the tested commit id. Some pre-requisites must be installed before or
after a missing tool failure is encountered, e.g. pkg-config on mac or
webrtc/src/build/install-build-deps.sh on linux.
Tested: linux and mac builds worked from clean virtual machines. Demos
and tests passed.