-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed critical issue in copying large files #7
base: main
Are you sure you want to change the base?
Conversation
Is it working on android 7.0? |
https://developer.android.com/reference/java/nio/file/package-summary Added in API level 26 I previously added this API but changed to FileChannel because we need to support android 7.0+ (api 24+) |
Hmm.. my app has min version 26 so this was not a problem. How about this code?
(untested, but should work). The main problem with the previous code is that |
Could you test in android emulator with api 24? I can do it also but on Wednesday. |
Not able to download files above 1GB . Please provide fix for this |
Did you try the code in the PR? I tested it and it works for files over 4GB with no problems |
I tried code from PR still same issue |
Hmm.. not sure, will take a look later. The code works fine, and it is already in production, so not sure what's wrong with your version |
Critical issue in android for copying large files: previous version downloads the large file but does not copy anything over 2GB.
Sorry! This PR fixes it.