Add settings icon in search popup

[kesselborn]

No description provided.

[grahamperrin]

From the sidebar issue, where there's a screenshot of what I see as primarily a search interface:

… what would be important features for you? …

I'd like search to be reasonably comprehensive, not limited to title and URL, but re: Implement search · Issue #4 · jonathanKingston/sea-containers I know to expect a performance impact when seeking within e.g. page content.

I'm the type of user who's seeking a successor to CacheViewer, with which e10s is incompatible – in the past I used that extension only rarely, but (without descending into a mini-rant) the Firefox transition to WebExtensions is causing me to re-seek power tools.

I foresee myself having a sidebar open, to the left, nearly always in all windows:

• using the sidebar predominantly for a group management extension that's based on e.g. tabgroup (not on containers)
• whilst occasionally using e.g. the toolbar button of Taborama to drop down a search interface
• with the button positioned to minimise the likelihood of the search interface obscuring any part of the sidebar when it drops

– does that make sense?

Thanks, HTH

[kesselborn]

Thanks for your input, although they don't quite fit the issue, which is just to have an icon in the search bar to quickly jump to the addon's preferences page.

I'd like search to be reasonably comprehensive, not limited to title and URL, but re: Implement search · Issue #4 · jonathanKingston/sea-containers I know to expect a performance impact when seeking within e.g. page content.

search will not be more than title and url in this addon -- it would broaden the scope to much

using the sidebar predominantly for a group management extension that's based on e.g. tabgroup (not on containers)

If tab containers will stay in firefox, I plan to use that feature for tab-grouping as well as this keeps the code small and I don't see any bigger disadvantages of using containers for this

[grahamperrin]

Thanks,

the issue, which is just to have an icon in the search bar

– sorry for misunderstanding.

[smichel17]

I presume this would go at the top, to the right of the search bar. When there id's text is in the search bar, the bar should expand and hide the icon; I wouldn't want to lose usable space in the search bar to a shortcut that I will almost never use (tbh, I'm fine with the current right click implementation and have never wished for a settings icon; I don't think one is necessary, as long as the user is prompted to visit the settings once to set them initially, you could just include a line of text in the settings explaining the right click behavior).

[kesselborn]

Yeah … that’s how it would look like. This is super low prio and the bug was done before I had the settings in the context menu. Perhaps I won’t implement it … it’s more of a reminder once I get bored ;)

…

On 24. Oct 2017, at 15:19, smichel17 ***@***.***> wrote: I presume this would go at the top, to the right of the search bar. When there id's text is in the search bar, the bar should expand and hide the icon; I wouldn't want to lose usable space in the search bar to a shortcut that I will almost never use (tbh, I'm fine with the current right click implementation and have never wished for a settings icon; I don't think one is necessary, as long as the user is prompted to visit the settings once to set them initially, you could just include a line of text in the settings explaining the right click behavior). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvjWgjfrNjqkJYkROGAGLlrA47Aehsks5svePSgaJpZM4PBTsc>.

[grahamperrin]

Looks fine to me. With conex settings as a menu option (without an icon). Intuitive.

As a minor improvement, you might use uppercase C for Conex

[kesselborn]

haha ... noted and changed -- but will sneak it into another release ;)