Allow changing the container of a new tab in private mode

[smichel17]

This is the context: mozilla/multi-account-containers#245 (comment)

Contrary to changing the container of an existing tab, there is no privacy implication to changing the container of a new tab in which I have typed the url but have not yet hit enter (possible exception: search suggestions; maybe require they be disabled to enable this functionality in private mode?).

Since the Mozilla folks seem not interested in responding* to that comment, I'm hoping you will be more receptive, or more receptive :)

*implementing or telling me why they think I'm wrong

[kesselborn]

I like the mockup and the idea. With web extensions something similar could be achieved with the following limitations:

• it's not possible to make it as nice looking (different colors are not possible, just plain text)
• only the first six suggestions will be displayed, i.e. if you have more than six containers, only six can be shown in the location bar

[kesselborn]

Using the omnibox has some annoying limitations (see markings on image):

• you need to prefix your url or search with a keyword (I chose tab here)
• the text is one character behind of the text in the omnibox (that can probably be fixed ... just did a quick test)
• there is no way to style the text behind the url (green in the image) and it is always prefixed with the keyword (again: here the keyword is tab)
• there is no way to set a custom icon ... not that important
• entries are limited to 6 entries

... as those are all limitations an addon cannot overcome, I doubt there is a way to implement this using the omnibox

[smichel17]

Ah, didn't mean that mockup necessarily. For this extension, I just figured it would use the same interface that already exists for changing containers.

[smichel17]

Hmm, other extensions (context plus and container switch) seem not to be able to change the container of a new tab -- maybe this is not possible in the webextension api?

[kesselborn]

well: it's not possible to intercept the action of pressing enter in the location bar.

• Taborama will open a new tab in the same container by default when pressing CTRL-T
• I will add the possibility to change the container for new tabs (currently, the page action is hidden on new tabs)

... is that what you meant with "use the same interface that already exists for changing containers"? It's not exactly the same but would perhaps be an okayish compromise

[smichel17]

Yes, that's what I meant :)

[kesselborn]

cool ... it's in v0.0.42 ;)

[smichel17]

Got it! A few things:

• Would it be possible to enable this even when privacy mode is selected, but only on the new tab page? I don't think there are the same privacy concerns as changing an existing tab, because nothing has been requested yet (as noted earlier, with the possible exception of search suggestions).
• On the new tab page, any text that's in the omnibar when you change the container is lost. Is it possible to save and re-populate it?

aside: wow, that turnaround time was really impressive

[kesselborn]

• what does "when privacy mode is selected" exactly mean? You mean the taborama setting about moving tabs between containers? If yes, that would make sense ... could you create an issue for this if that's what you mean?
• regarding the second point: this would be a very hackish solution where the addon would pretentd to be an omnibox extension without actually being one ... not sure it's possible to make that a good user experience

[smichel17]

very hackish solution where the addon would pretentd to be an omnibox extension without actually being one

I'm not familiar with the webextensions api, so I'm not sure what pretending vs actually being an omnibox extension means. However, I think it is a bad user experience to open a new tab, type a uri, change the container, and then have whatever you just typed disappear.

I will create a new issue for both :)