Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open tab in different containers with location bar pre-filled #45

Closed
smichel17 opened this issue Sep 23, 2017 · 8 comments
Closed

open tab in different containers with location bar pre-filled #45

smichel17 opened this issue Sep 23, 2017 · 8 comments

Comments

@smichel17
Copy link
Contributor

Steps to reproduce:

  • Open a new tab
  • Enter https://duckduckgo.com, but do not press enter
  • Change the tab to a different container

Expected result: https://duckduckgo.com remains in the omnibar
Actual result: Omnibar is cleared

I know this is technically the intended behavior right now, but it feels like a bug to me.

@kesselborn
Copy link
Owner

  • regarding loss of content in form fields: this would add a lot of code and never get stable, so I would not even look into this. Note as well that this says: repopen tab in other container, not move tab to other container -- I kind of hoped that this would not make people to expect that input gets saved during this operation (though I guess that's a very technical point of view ;) )
  • regarding the original bug: while I could read the text that is currently typed in into the location bar via the omnibox permission, it is not possible to open a new tab and prefil the location bar in the same way -- it's technically not possible

I will add an explanation to the settings dialog that will explain this behavior and then close this bug.

Thanks a lot for the report though.

@smichel17
Copy link
Contributor Author

@kesselborn is it possible to read the text in the omnibox and copy it to the clipboard?

@kesselborn
Copy link
Owner

Not sure, but I don’t think so. Apart from that: I would not think that this is a good solution:

  • the feature would not be easily discoverable for users unless a dialog on first use would be shown (which is not a good thing I think)
  • it could overwrite something important in the clipboard without the user’s consent, which would be a bad experience
  • frankly I don’t think that this feature is important enough for all the potential problems: once you know that your text will get lost, you can quickly copy the text of the location bar by doing a ctrl-a ctrl-c beforehand which is straight forward and standard

@smichel17
Copy link
Contributor Author

it is not possible to open a new tab and prefil the location bar in the same way -- it's technically not possible

I wonder if Mozilla would be willing to add this functionality. I suppose I shall need to file a bug with them :)

@smichel17
Copy link
Contributor Author

@kesselborn What if the functionality were modified so that "changing container" of a new tab opens whatever URL is typed in the omnibar in the selected container (ie, the functionality of https://github.com/kesselborn/taborama/issues/42#issuecomment-331249276, but using the current interface). Then just make a small tweak to the text:

re-open -> open
textchange

@kesselborn
Copy link
Owner

regarding mozilla adding this functionality: I would be surprised as there will be a lot of unanswered problems for a (I think) niche problem:

  • how will users discover the feature
  • how to prevent, that while users are typing, web-extensions will alter the text
  • etc.
    ... I could be wrong though

regarding the solution with the different context menu: I will play around with this, though I would not see it a high priority right now.

Thanks

@kesselborn kesselborn changed the title New tab text is lost upon changing containers open tab in different containers with location bar pre-filled Sep 26, 2017
@kesselborn
Copy link
Owner

changing tabs to a different container is now not part of conex anymore but a Firefox feature ... closing this bug as I can't fix it (firefox has the same behavior though)

@ghost ghost removed the backlog label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants