Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VariableCondition to ExpressionCondition or just Condition/Expression #3790

Closed
anna-geller opened this issue May 21, 2024 · 0 comments · Fixed by #3791
Closed

Rename VariableCondition to ExpressionCondition or just Condition/Expression #3790

anna-geller opened this issue May 21, 2024 · 0 comments · Fixed by #3791
Assignees
Milestone

Comments

@anna-geller
Copy link
Member

Issue description

we used to call Pebble expressions "Variables" but we no longer do it. Given we do the entire renaming in 0.17, worth renaming this one too https://develop.kestra.io/plugins/core/conditions/condition/io.kestra.plugin.core.condition.variablecondition

Current:

- conditions:
    - type: io.kestra.plugin.core.condition.VariableCondition
      expression: {{ unknown is defined }}

Perhaps we can do this instead?

- conditions:
    - type: io.kestra.plugin.core.condition.Expression
      expression: {{ unknown is defined }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants