Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Date parsing should not apply when rendering vars as it coul… #1071

Merged
merged 3 commits into from Mar 23, 2023
Merged

fix(UI): Date parsing should not apply when rendering vars as it coul… #1071

merged 3 commits into from Mar 23, 2023

Conversation

brian-mulier-p
Copy link
Member

…d lead to confusion

Was wondering about trying to find out a rule to parse it in certain case but it feels too tricky and I think that in any case you would prefer to see raw inputs and outputs to prevent confusion

close #1070

@tchiotludo
Copy link
Member

I really want to keep the auto date parsing, since this component is used everywhere.
Maybe a simple regexp like ^(?:\d{4})-(?:\d{2})-(?:\d{2}) will do the trick to be sure it's a date or a datetime?

@brian-mulier-p
Copy link
Member Author

That's what I thought at first but navigating in the app and regarding where the code is used, I didn't find any inconvenience removing it ?
image
image

@tchiotludo
Copy link
Member

For every trigger (schedule), we will lose the major improvement on date display

@brian-mulier-p
Copy link
Member Author

I didn't use triggers yet but I see the point now, sorry, I will add the regex

@brian-mulier-p
Copy link
Member Author

I've added the regex filter :)

@tchiotludo tchiotludo merged commit 558c41e into kestra-io:develop Mar 23, 2023
5 checks passed
@brian-mulier-p brian-mulier-p deleted the fix/removeDateParsingForVars branch April 14, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4-digits String as inputs are considered as a date when displayed
2 participants