-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global trajectory parameters #41
Conversation
Signed-off-by: ErikQQY <2283984853@qq.com>
hey @ErikQQY the tests failed, looks like a variable should be uppercase, check the comment I left. It looks good otherwise tho! Let's get the tests passing and we'll merge it in. |
The documentations has been added |
bump, if there is still something missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving!
@ErikQQY sorry, I caught something, and have been under the weather, it is merged in! Thanks so much! |
Wishing you all good! Take care!!! |
Fix: #37