Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global trajectory parameters #41

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

ErikQQY
Copy link
Contributor

@ErikQQY ErikQQY commented May 30, 2024

Fix: #37

Signed-off-by: ErikQQY <2283984853@qq.com>
@aarontrowbridge
Copy link
Collaborator

hey @ErikQQY the tests failed, looks like a variable should be uppercase, check the comment I left. It looks good otherwise tho! Let's get the tests passing and we'll merge it in.

Signed-off-by: ErikQQY <2283984853@qq.com>
@aarontrowbridge
Copy link
Collaborator

CI is running, last thing @ErikQQY, can you add a docs file in line with the last bullet in the issue #41. :) looks good otherwise 👍

Signed-off-by: ErikQQY <2283984853@qq.com>
@ErikQQY
Copy link
Contributor Author

ErikQQY commented Jun 1, 2024

The documentations has been added

@ErikQQY
Copy link
Contributor Author

ErikQQY commented Jun 6, 2024

bump, if there is still something missing?

Copy link
Collaborator

@aarontrowbridge aarontrowbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good!

Copy link
Collaborator

@aarontrowbridge aarontrowbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving!

@aarontrowbridge aarontrowbridge merged commit 355528a into kestrelquantum:main Jun 6, 2024
4 checks passed
@aarontrowbridge
Copy link
Collaborator

@ErikQQY sorry, I caught something, and have been under the weather, it is merged in! Thanks so much!

@ErikQQY
Copy link
Contributor Author

ErikQQY commented Jun 6, 2024

Wishing you all good! Take care!!!

@ErikQQY ErikQQY deleted the qqy/params branch June 7, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Global Trajectory Parameters
2 participants