This repository has been archived by the owner on Dec 21, 2019. It is now read-only.
A bit more Scala friendlyness #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Hofer <joachim.hofer@johoop.de>
|
Did you open a bug at Eclipse.org for that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I don't know what exactly is going on with AbstractSWTBot.click() vs. SWTBotToolbarButton.click() vs. SWTBotToolbarPushButton.click(), but something about this makes Scala reject simple commands like "bot.get.toolbarButton(1).click()".
So I removed the intermediate abstract method. Maybe you can take this little patch under consideration?
The tests all still run (except for the ui tests dependent on the en_US keyboard layout, which don't run in my de_DE environment).
Cheers,
Joachim