New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added 4(3) pairs of Zonneveld and Söderlind #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 79.41% 79.45% +0.04%
==========================================
Files 21 21
Lines 4499 4508 +9
==========================================
+ Hits 3573 3582 +9
Misses 926 926
Continue to review full report at Codecov.
|
@@ -2587,6 +2589,8 @@ def loadRKM(which='All'): | |||
* 'DP5': Dormand-Prince 5th-order :cite:`dormand1980` | |||
* 'PD8': Prince-Dormand 8th-order and 7th-order pair :cite:`prince1981` | |||
* 'CMR6': Calvo et al.'s 6(5) pair :cite:`calvo1990` | |||
* 'Zonneveld43': 4(3) pair of Zonneveld :cite:`hairer1993` Table 4.2 | |||
* 'Söderlind43': 4(3) pair of Söderlind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already merged this but the second character makes it rather challenging to load this method on a non-german keyboard. Perhaps better to go with convenience over perfect spelling in this situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you're right. Although it is not really hard to do (I'm using an English keyboard right now). In Linux, there is a compose key to write such characters.
Shall I rename Söderlind43 to Soderlind43?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I rename Söderlind43 to Soderlind43?
Yes, I think it's for the best and that Gustaf will forgive us. :)
No description provided.