Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 4(3) pairs of Zonneveld and Söderlind #60

Merged
merged 2 commits into from Dec 1, 2019
Merged

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Nov 29, 2019

No description provided.

@coveralls
Copy link

coveralls commented Nov 29, 2019

Coverage Status

Coverage increased (+0.04%) to 79.459% when pulling db03c84 on ranocha:rk43 into db1e69f on ketch:master.

@codecov-io
Copy link

Codecov Report

Merging #60 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   79.41%   79.45%   +0.04%     
==========================================
  Files          21       21              
  Lines        4499     4508       +9     
==========================================
+ Hits         3573     3582       +9     
  Misses        926      926
Impacted Files Coverage Δ
nodepy/runge_kutta_method.py 86.25% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1e69f...db03c84. Read the comment docs.

@ketch ketch merged commit a52ea9e into ketch:master Dec 1, 2019
@@ -2587,6 +2589,8 @@ def loadRKM(which='All'):
* 'DP5': Dormand-Prince 5th-order :cite:`dormand1980`
* 'PD8': Prince-Dormand 8th-order and 7th-order pair :cite:`prince1981`
* 'CMR6': Calvo et al.'s 6(5) pair :cite:`calvo1990`
* 'Zonneveld43': 4(3) pair of Zonneveld :cite:`hairer1993` Table 4.2
* 'Söderlind43': 4(3) pair of Söderlind
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already merged this but the second character makes it rather challenging to load this method on a non-german keyboard. Perhaps better to go with convenience over perfect spelling in this situation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you're right. Although it is not really hard to do (I'm using an English keyboard right now). In Linux, there is a compose key to write such characters.
Shall I rename Söderlind43 to Soderlind43?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I rename Söderlind43 to Soderlind43?

Yes, I think it's for the best and that Gustaf will forgive us. :)

@ranocha ranocha mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants