Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adsb exchange feeder and mlat #20

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Add adsb exchange feeder and mlat #20

merged 4 commits into from
Mar 22, 2021

Conversation

garethhowell
Copy link

This change adds two new services to send data from dump1090-fa to adsbexchange.com

  • adsbexchange-feed and
  • adsbexchange-mlat

Strictly speaking, adsbexchange-mlat's services could be provided using the pre-existing mlat-client service.

@ketilmo
Copy link
Owner

ketilmo commented Mar 15, 2021

Hi @garethhowell,

Thanks a lot for contributing to the balena ADS-B project! That's highly appreciated. I will have a look at your pull request as soon as possible and come back to you. Thanks again!

Ketil

@ketilmo
Copy link
Owner

ketilmo commented Mar 22, 2021

Hi @garethhowell,

Thanks for submitting a fully functional implementation of the ADSB Exchange feeder. I have reviewed your pull request, and it looks good.

I have made a few slight changes:

  • I have changed the variable ADSBEXCHANGE_RECEIVER_NAME to ADSB_EXCHANGE_SITENAME to ensure future compatibility with some ongoing implementation work.
  • I have added a variable called ADSB_EXCHANGE_UUID for seamless future addition of ADSB Exchange's statistics package.
  • I have added scripts for generating a legal site name and a proper UUID (see readme).

That's it! Your pull request is good to go.

Thanks again for your efforts! Good work!

Kind regards,
Ketil

@ketilmo ketilmo merged commit 60f3707 into ketilmo:master Mar 22, 2021
ketilmo added a commit that referenced this pull request Mar 22, 2021
ketilmo added a commit that referenced this pull request Mar 22, 2021
@garethhowell garethhowell deleted the add-adsb-exchange branch March 24, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants