Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider "react-responsive" optimization #51

Closed
kettanaito opened this issue Jul 22, 2018 · 2 comments
Closed

Consider "react-responsive" optimization #51

kettanaito opened this issue Jul 22, 2018 · 2 comments
Assignees
Milestone

Comments

@kettanaito
Copy link
Owner

kettanaito commented Jul 22, 2018

What

Maybe it's worth looking into optimizing "react-responsive" package built-in into the library.

Why

react-responsive takes almost a half of the library's bundle size. It's always good to ship a smaller package, that evaluates and runs faster.

How

If react-responsive allows es/src imports, those can be included and processed via library's webpack. This can improve the bundle size via tree shaking, for example, as Atomic layout doesn't utilize all features of react-responsive.

Alternatively, can do a PoC to include a custom responsive utility, covering only the required aspects.

@kettanaito kettanaito added this to the Optimization milestone Jul 22, 2018
@kettanaito kettanaito added the help wanted Extra attention is needed label Feb 11, 2019
@kettanaito
Copy link
Owner Author

#115 Gets rid of react-responsive dependency, eliminating deep sub-dependency's bug, and making the overall bundle size smaller.

@kettanaito kettanaito self-assigned this Feb 18, 2019
@kettanaito kettanaito removed the help wanted Extra attention is needed label Mar 6, 2019
@kettanaito
Copy link
Owner Author

atomic-layout@beta and the upcoming minor versions are dependency-free, thus there is nothing to optimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant