-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use own "MediaQuery" component over "react-responsive" #115
Conversation
552eca4
to
5012772
Compare
d89ca03
to
6282a8c
Compare
f921257
to
8c6d4dd
Compare
Performing manual testing... Will write report once done. ReportOwn
atomic-layout/src/components/MediaQuery.tsx Lines 31 to 34 in 07ae66b
|
07ae66b
to
9287595
Compare
9287595
to
2bec5c5
Compare
The usage of |
Automated and manual testing passes. The only thing left is to restore/improve test coverage. Update: Test coverage should be restored now, but Coveralls is stuck reporting. |
These changes aim to provide a custom implementation of
MediaQuery
component to use in Atomic layout package.Motivation
At the moment Atomic layout relies on a single dependency
react-responsive
. It composes nearly a half of theatomic-layout
package size, and has a deep dependency tree of its own. Everything gets bundled and shipped underatomic-layout
package.Dependencies investigation has shown that some of the deep dependencies of
react-responsive
are obsolete, and contain implementation that causes unexpected behaviors (found out during SSR exceptions due to invalid media query RegExp). Those directly affect the behavior of Atomic layout.Goals
Roadmap
react-responsive
dependency and its usageMediaQuery
componentMediaQuery
components