Uses "useResponsiveQuery" hook over "withPlaceholder" in Only component #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
308-only-rerender
branch
from
0e65a49
to
3e4c173
Compare
|
Hi, @Vidlec. Could you please get a look at this pull request? It should fix the issue you are experiencing. Thank you! |
Vidlec
previously approved these changes
Apr 1, 2020
kettanaito
commented
Apr 1, 2020
| // Render always when no constrains are provided | ||
| return <>children</> | ||
| const matches = useResponsiveQuery({ for: exactBreakpoint, from, to, except }) | ||
| return matches && <Box {...restProps}>{children}</Box> |
There was a problem hiding this comment.
Instead of rendering in a fragment and deligating the restProps assignment to the withPlaceholder (MediaQuery, effectively), the Only component now renders a Box, to which it assigns all the passed box props. This should not introduce any breaking changes, as it's a matter of moving the abstracted parent component up to the application surface.
kettanaito
commented
Apr 1, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Release version
Contributor's checklist
masteryarn verifyto see the build and tests pass