Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses "useMediaQuery" instead of MediaQuery component #313

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Uses "useMediaQuery" instead of MediaQuery component #313

merged 1 commit into from
Apr 5, 2020

Conversation

kettanaito
Copy link
Owner

Changes

  • Removes the MediaQuery component
  • Uses useMediaQuery hook for withPlaceholder() high-order component function that wraps conditional areas

Issues

Release version

  • internal (no release required)
  • patch (bug fixes)
  • minor (backward-compatible changes)
  • major (backward-incompatible, breaking changes)

Contributor's checklist

  • My branch is up-to-date with the latest master
  • I ran yarn verify to see the build and tests pass

@kettanaito kettanaito merged commit 2ddce1d into master Apr 5, 2020
@kettanaito kettanaito deleted the 309-ditch-media-query branch April 5, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "MediaQuery" component with "useMediaQuery" hook
1 participant
@kettanaito