Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible simplification of shouldDisplayPagination #6

Closed
wflemingnz-retired opened this issue Jan 15, 2021 · 2 comments · Fixed by #18
Closed

Possible simplification of shouldDisplayPagination #6

wflemingnz-retired opened this issue Jan 15, 2021 · 2 comments · Fixed by #18

Comments

@wflemingnz-retired
Copy link

Great summary.

One question/suggestion - wouldn’t:

const shouldDisplayPagination = (postsCount > 10) // alternatively

be better as:

const shouldPaginate = (postsCount > 10) // alternatively

The latter is more concise and I think expresses the meaning better(though I could have the meaning wrong).

@kettanaito
Copy link
Owner

Hey, @wflemingnz. That's a great suggestion. Would you mind issuing a pull request that implements it?

@wflemingnz-retired
Copy link
Author

Yep, may be a week or so away though.

donatoaguirre24 added a commit to donatoaguirre24/naming-cheatsheet that referenced this issue Jan 17, 2021
alvorie added a commit to alvorie/study-fork that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants